Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump node to current LTS & adapt build accordingly #149

Merged

Conversation

BastienGauthier
Copy link
Contributor

@BastienGauthier BastienGauthier commented Nov 9, 2023

This fix #127

The main blocker was streamlit-component-lib not upgrading to v2

@blackary
Copy link
Collaborator

blackary commented Nov 9, 2023

I think it's probably best to actually pin the package requirements as well until we figure out a solution to the folium 0.15 bug

@BastienGauthier
Copy link
Contributor Author

BastienGauthier commented Nov 9, 2023

I think it's probably best to actually pin the package requirements as well until we figure out a solution to the folium 0.15 bug

Not sure hat you mean here : I set folium>=0.13,<0.15 for both requirement.txt files already. You mean you want folium==0.14 exactly ?

@blackary
Copy link
Collaborator

blackary commented Nov 9, 2023

Sorry, it's a bit confusing -- there are 3 different sets of requirements in this repo:

  1. requirements.txt -- for the demo app
  2. test/requirements.txt -- for the tests
  3. setup.py -- for the package

You should actually just be able to change the requirements in the package, and have it work, since the requirements.txt files should also install the package dependencies

@BastienGauthier
Copy link
Contributor Author

done !

Copy link
Collaborator

@blackary blackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blackary blackary requested a review from randyzwitch November 9, 2023 16:38
@randyzwitch randyzwitch merged commit b08da91 into randyzwitch:master Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade node versions in build scripts
3 participants