Ability to provide feature group as list #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aring as requested
|
ah yes sorry just saw I forgot to update tests/test_package.py, but you did it anyway, thx |
|
Needed to do some linting, which you can do on your own with |
blackary
approved these changes
Dec 11, 2023
|
Thanks @patrontheo! |
|
Great work @patrontheo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It gives the ability to provide feature groups as list
It fixes #163 and (includes #164)
I added tests to make sure it works.
@blackary I am not an expert with this testing library, so I used the styling to make sure the layer is shown or not. There is probably a better way of doing it.
It partially addresses #153 (possibility to pass a list of feature groups).
However, the layerControl is still not available.