Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error where default_css was missing #201

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Fix error where default_css was missing #201

merged 5 commits into from
Jul 10, 2024
+45 −28

Conversation

blackary
Copy link
Collaborator

@blackary blackary commented Jul 9, 2024

  • Ignore elements where there is no special css or js to load
  • Add test to check for regression on geojson popup
  • Fix selectors for a few tests
  • Bump version to 0.21.1

Fixes #200
Fixes #199

blackary added 2 commits July 9, 2024 17:08
@blackary
Fix error where default_css was missing
1840776 
* Ignore elements where there is no special css or js to load
* Add test to check for regression on geojson popup
* Fix selector for other popup test
* Bump version to 0.21.1
@blackary
Fix a few tests
8da17a0
@blackary blackary requested a review from randyzwitch July 9, 2024 21:31
randyzwitch
randyzwitch approved these changes Jul 9, 2024
View reviewed changes
Copy link
Owner

@randyzwitch randyzwitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, waiting for tests to pass

@blackary
Copy link
Collaborator Author

Had to fiddle with some selectors to get it working both locally and on github actions, not totally sure why the discrepancy, but now it's working @randyzwitch

@randyzwitch randyzwitch merged commit 58b14d7 into master Jul 10, 2024
5 checks passed
@randyzwitch randyzwitch deleted the handle-missing-css branch July 10, 2024 15:10
big-yellow-duck added a commit to big-yellow-duck/streamlit-folium that referenced this pull request Jul 12, 2024
@big-yellow-duck
Merge pull request #1 from randyzwitch/master
b911971 
Fix error where default_css was missing (randyzwitch#201)
@connortann connortann mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyzwitch randyzwitch randyzwitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GeoJSON Popup is broken AttributeError: 'StepColormap' object has no attribute 'default_css'
2 participants
@blackary @randyzwitch