Added max_drawn_objects argument #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a nice addition, thanks! Would you be interested in trying to add a test showing this in action on the draw examples page? You can look in test_frontentend.py for examples. If not, I can try and add one at some point. |
|
Please also remove any files that are not part of the actual PR |
randyzwitch
reviewed
Jul 12, 2024
|
I'll clean it up and make a page for it |
|
I updated the PR. but I haven't updated the tests yet. But it's working through by running the example by hand in the draw support page |
|
Latest failure due to whitespace in pre-commit check @big-yellow-duck https://github.com/randyzwitch/streamlit-folium/actions/runs/9912015159/job/27460574420?pr=202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the max_drawn_objects arguement is not 0, the number of drawn objects can be limited by removing the oldest drawn objects in map