Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global reference to the Streamlit library #230

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

hansthen
Copy link
Contributor

@hansthen hansthen commented Oct 12, 2024

I noticed the Streamlit.setComponentValue() example (in realtime.py) was no longer working. For some reason, in the latest releases the Streamlit library is no longer in the global namespace. This change adds it back to the window namespace, so JsCode callbacks in Folium can return values to Streamlit.

Closes #231

I noticed the Streamlit.setComponentValue() example
was no longer working. For some reason, in the latest
releases the Streamlit library is no longer in the
global namespace. This change adds it back to the
window namespace, so JsCode callbacks in Folium can
return values to Streamlit.
@blackary
Copy link
Collaborator

Looks good to me. The linting failure should be fixed once #232 is merged in

@randyzwitch
Copy link
Owner

@blackary unfortunately, that didn't fix it, just moved to a different error I think

Copy link
Collaborator

@blackary blackary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@randyzwitch randyzwitch merged commit b094a9e into randyzwitch:master Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

realtime example fails to return data
3 participants