Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eagerly populate the class dict for cudf.pandas proxy types #14534
Eagerly populate the class dict for cudf.pandas proxy types #14534
Changes from 93 commits
dba3586
bd69575
16b9340
8953944
3a27c54
19e3038
cef9adc
73e714a
483872a
1066c2b
68df373
cdef427
8c14c0c
fef2768
b810679
d0f094b
7ef0757
5d53462
de5cb7a
4d928eb
a8f3222
8e9eaad
180228d
fbefc7f
eba403c
16a0f21
764bd72
a29df18
3290cc9
fd6adce
2f4fdb6
964d95f
1923bda
ef5784c
f6b6d4a
f56deb9
917a0b5
3d3ff0a
c95289a
16a647d
9891545
e3dc345
c2ca0c4
a078724
fa542bb
9526807
e5bdfd2
624c71e
442593a
bee2c92
e3f7393
2e38b7d
30e9b59
616b206
169148b
840c34e
979926b
e79568e
106ea90
761ab6d
9d7bea2
6b70dd3
c32c437
e4dd410
64905ad
01e5efa
a8969de
1fe2627
c9c5e65
a8220b9
f31f9bd
0e7c843
b37dd00
040fdb6
fa4367c
13f9e48
9495db3
de4d5ec
5cbfcfa
c9126ed
aa03e09
2399eb2
9e580e7
0b5ef86
9ac1363
fe7cb14
1b91665
61034bd
db4d356
f6a7042
9c9dc95
8488a02
129cd81
c6914fd
925374e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL a new part of the descriptors object model!
https://docs.python.org/3/howto/descriptor.html#closing-thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these attributes we are wanting the fast path to have a chance to evaluate and not automatically be
_Unusable()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so in this case since it's
private
we won't try to operate on e.g.cudf.Index._data
which is aColumnAccessor
and instead reach forcudf.Index._data
which is a numpy ndarray which we can wrap.This part of the eager population I'm not too thrilled about. These private variables are not guaranteed to be stable. It would be nice if any slow attribute was attempted to return a proxy object so we didn't have to specify attributes like this but I suppose that can be looked at in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, there are still such cases we can address in follow-ups. At this point the scope of this PR has kept on expanding, that's why I haven't addressed additional issues in this PR.