-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields to Parquet Statistics structure that were added in parquet-format 2.10 #15412
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
67b1475
statistics are always exact
etseidl 3957e09
update copyright date
etseidl c54a4dc
Merge branch 'branch-24.06' into exact_stats
etseidl 2f64fb9
typo
etseidl 88e3f95
Merge branch 'exact_stats' of github.com:etseidl/cudf into exact_stats
etseidl 34be6fc
Merge branch 'branch-24.06' into exact_stats
etseidl 1ace27e
Merge branch 'branch-24.06' into exact_stats
etseidl 61d56a5
Merge branch 'branch-24.06' into exact_stats
etseidl 921a1e9
Merge branch 'branch-24.06' into exact_stats
etseidl 8851236
Merge branch 'rapidsai:branch-24.06' into exact_stats
etseidl 775eeae
Merge branch 'branch-24.06' into exact_stats
etseidl fb2f98b
Merge branch 'rapidsai:branch-24.06' into exact_stats
etseidl e278073
Merge branch 'branch-24.06' into exact_stats
etseidl 1a6144f
Merge branch 'branch-24.06' into exact_stats
etseidl f1c9ef4
Merge branch 'branch-24.06' into exact_stats
etseidl 3561067
Merge branch 'branch-24.06' into exact_stats
etseidl de92251
Merge branch 'branch-24.06' into exact_stats
etseidl 299a29d
Merge remote-tracking branch 'origin/branch-24.06' into exact_stats
etseidl 4e980bb
Merge branch 'branch-24.06' into exact_stats
ttnghia b694518
Merge branch 'branch-24.06' into exact_stats
ttnghia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can both of these fields be present (as
true
) even if the stats does not have min and max value?I hope, other parquet readers don't break if this is
true
when min and max values are missing in stats.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...good point. As currently written, the stats encoding will always write something in the min and max fields if
s->has_minmax
is true, so I think it's safe to always set theexact
fields to true here.That said, the rules around when min/max should have values encoded and not have been in flux (and as with everything Parquet, are not well documented), so it would probably be a good idea to make sure we're following all of the rules properly. I'm not sure if that's in scope for this PR or should be a separate issue.