Minor fixups for future NumPy 2 compatibility #15590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alternative is listing them all, but even that is a bit tedious for integers, because it needs something like: ``(np.byte, np.short, np.intc, getattr(np, "long", np.int_), np.longlong)``
galipremsagar
requested changes
Apr 24, 2024
Co-authored-by: GALI PREM SAGAR <[email protected]>
Yeah good point, should have noticed that it was just duplicating the tests. |
galipremsagar
approved these changes
Apr 24, 2024
galipremsagar
added
improvement
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some small fixes to be compatible with NumPy 2 python changes, as pointed out by the
ruffwith the"NPY201"rule-set.I am not really happy with the
_NUMPY_SCTYPES(reaching into what is now private, but figured that others will do so also for a while; feels like we should add a better way to do this in NumPy before removing it).Listing the full set is also a bit ugly/convoluted, but happy to do so instead.
(I was hoping to get a bit further with testing against the NumPy 2rc, but unfortunately the
numbadependency makes that at least difficult.)xref: rapidsai/build-planning#38