Deprecate to/from_dask_dataframe APIs in dask-cudf
#15592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjzamora
added
2 - In Progress
28 tasks
rjzamora
added
3 - Ready for Review
This was referenced Apr 24, 2024
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Apr 25, 2024
Minor notebook change. Motivated by rapidsai/cudf#15592 @taureandyernv - Just an FYI: I'm sure there is plenty of example code/documentation floating around that uses `dask_cudf.to/from_dask_dataframe`. I will be looking for this, and changing it to `*.to_backend("cudf"/"pandas")`. Feel free to point out problem areas :) Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) - Dante Gama Dessavre (https://github.com/dantegd) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #5862
rjzamora
added
4 - Needs Review
charlesbluca
suggested changes
Apr 29, 2024
rjzamora
commented
Apr 29, 2024
Co-authored-by: Charles Blackmon-Luca <[email protected]>
…a/cudf into deprecate-to-from-dask-dataframe
…o-from-dask-dataframe
…a/cudf into deprecate-to-from-dask-dataframe
rjzamora
added
5 - Ready to Merge
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
to/from_dask_dataframeAPIs have been obsolete for a long time. It is always better to useddf.to_backend("cudf")orddf.to_backend("pandas")instead.These APIs are also "dangerous" to use with dask-expr, because the same API names are still used to convert data to/from "legacy" Dask collections. Note that dask-expr also deprecated
to/from_dask_dataframein favor ofto/from_legacy_dataframe, but the conflicting APIs still exist (for now).Checklist