Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JNI build to support nvcomp4 #16250

Closed
wants to merge 1 commit into from

Conversation

pxLi
Copy link
Member

@pxLi pxLi commented Jul 11, 2024

Description

Prepare the PR to support bumping up nvcomp version to 4.0+
Some notable changes:

  1. libnvcomp_gdeflate.so and libnvcomp_bitcomp.so have been absorbed into libnvcomp.so
  2. libnvcomp.so is now a symlink in nvcomp tarball, so we copy the actual libnvcomp.so.x.y.z as libnvcomp.so during static linking to avoid breaking the following builds.

These changes have been verified internally

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@pxLi pxLi added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuDF (Java) labels Jul 11, 2024
Copy link

copy-pr-bot bot commented Jul 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake CMake build issue label Jul 11, 2024
@pxLi
Copy link
Member Author

pxLi commented Jul 11, 2024

@vuule please help include this commit while you update nvcomp4 in cudf, thanks

#16076

Signed-off-by: Peixin Li <[email protected]>
Co-authored-by: Yinqing Hao <[email protected]>
@pxLi pxLi force-pushed the JNI-to-support-nvcomp4 branch from 074571d to 05d6289 Compare July 11, 2024 02:54
@robertmaynard robertmaynard mentioned this pull request Jul 22, 2024
3 tasks
@bdice
Copy link
Contributor

bdice commented Sep 5, 2024

Closing this in favor of #16076, which includes these changes -- thanks @pxLi, this was helpful!

@bdice bdice closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants