-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make conda installs in CI stricter #17013
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e6207d1
make package installations in CI stricter
jameslamb 90a3979
revert the cudf-polars changes (polars needs to be installed first)
jameslamb 278ecec
Merge branch 'branch-24.12' of github.com:rapidsai/cudf into ci-conda…
jameslamb 911e9e4
Merge branch 'branch-24.12' of github.com:rapidsai/cudf into ci-conda…
jameslamb 16367a5
clean up variables
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
build_docs.sh
weexport
this, but here we're just setting it locally. I doubt it matters here but it might be worth establishing consistent patterns. Also applies to other files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking here was "export it if it's already exported (as in the docs example), otherwise make it local", since I thought that had the least risk of causing other surprising problems.
I clicked around a little, and I think:
RAPIDS_VERSION
= does not even need to be set in docs-build scriptsRAPIDS_VERSION_MAJOR_MINOR
= does not need to be exportedRAPIDS_VERSION_NUMBER
= needs to be exported, forrapids-upload-docs
(code link in gha-tools)For all the other scripts that are not docs builds, this PR only introduces NEW variables, so I think not exporting them is slightly safer.
Just pushed 16367a5 doing that. If that works, I'll make similar changes in the other PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This went fine in CI... docs built successfully and I see the expected versions of things in the environment. Docs look ok at the preview too: https://downloads.rapids.ai/ci/cudf/pull-request/17013/16367a5/docs/libcudf/html/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these claims I made about the variables not needing to be exported were incorrect. Addressed in #17042 (and updated across all the other PRs for this issue).