Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] ORC debug #17357

Draft
wants to merge 21 commits into
base: branch-25.02
Choose a base branch
from

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Nov 18, 2024

Description

This PR is not intended for merge. It is forked off @mhaseeb123 's branch bug/orc-rle.

The main purpose is to investigate an ORC decoding bug.

Build with device debug symbols

In nvcc, compiler options -E and -MD cannot be used together. However:

  • Adding the device debug symbol (-G) for a selected set of .cu files appears to cause -MD to be added as a compiler option.
  • sccache always forces -E to be appended even when export CCACHE_DISABLE=1 is used.

Given this conundrum, the hacky solution is to remove the use of sccache directly from the build.ninja file, before building libcudf with the device debug symbol added. The script rebuild_example.sh implements this workaround.

  • To build libcudf with device debug symbols added to a selected set of .cu files + build the ORC example, run:
cd ~/cudf/cpp/examples/orc_io/debug
./rebuild_example.sh
  • To load preset breakpoints and step in the kernel, run:
./debug.sh

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Nov 18, 2024
@github-actions github-actions bot added Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Nov 20, 2024
@vyasr vyasr changed the base branch from branch-24.12 to branch-25.02 November 20, 2024 16:44
Copy link

copy-pr-bot bot commented Dec 4, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot removed Python Affects Python cuDF API. Java Affects Java cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels Dec 4, 2024
@kingcrimsontianyu kingcrimsontianyu force-pushed the orc-debug branch 4 times, most recently from 16f8173 to 0f510a6 Compare December 11, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants