-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] ORC debug #17357
Draft
kingcrimsontianyu
wants to merge
21
commits into
rapidsai:branch-25.02
Choose a base branch
from
kingcrimsontianyu:orc-debug
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[DO NOT MERGE] ORC debug #17357
kingcrimsontianyu
wants to merge
21
commits into
rapidsai:branch-25.02
from
kingcrimsontianyu:orc-debug
+1,044
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
Affects libcudf (C++/CUDA) code.
CMake
CMake build issue
labels
Nov 18, 2024
kingcrimsontianyu
force-pushed
the
orc-debug
branch
from
November 20, 2024 15:33
0253c1b
to
3bfe67b
Compare
github-actions
bot
added
Python
Affects Python cuDF API.
Java
Affects Java cuDF API.
cudf.pandas
Issues specific to cudf.pandas
cudf.polars
Issues specific to cudf.polars
pylibcudf
Issues specific to the pylibcudf package
labels
Nov 20, 2024
kingcrimsontianyu
force-pushed
the
orc-debug
branch
from
December 4, 2024 04:14
3bfe67b
to
dd5928e
Compare
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
removed
Python
Affects Python cuDF API.
Java
Affects Java cuDF API.
cudf.pandas
Issues specific to cudf.pandas
cudf.polars
Issues specific to cudf.polars
pylibcudf
Issues specific to the pylibcudf package
labels
Dec 4, 2024
kingcrimsontianyu
force-pushed
the
orc-debug
branch
4 times, most recently
from
December 11, 2024 14:59
16f8173
to
0f510a6
Compare
kingcrimsontianyu
force-pushed
the
orc-debug
branch
from
December 16, 2024 19:07
0f510a6
to
98b4d9f
Compare
kingcrimsontianyu
force-pushed
the
orc-debug
branch
from
December 19, 2024 14:15
98b4d9f
to
97a9c50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is not intended for merge. It is forked off @mhaseeb123 's branch bug/orc-rle.
The main purpose is to investigate an ORC decoding bug.
Build with device debug symbols
In nvcc, compiler options
-E
and-MD
cannot be used together. However:-G
) for a selected set of .cu files appears to cause-MD
to be added as a compiler option.sccache
always forces-E
to be appended even whenexport CCACHE_DISABLE=1
is used.Given this conundrum, the hacky solution is to remove the use of
sccache
directly from thebuild.ninja
file, before building libcudf with the device debug symbol added. The scriptrebuild_example.sh
implements this workaround..cu
files + build the ORC example, run:Checklist