Remove Thrust patch in favor of CMake definition for Thrust 32-bit offset types. #17527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
libcudf
vyasr
added
improvement
vyasr
approved these changes
Dec 5, 2024
vyasr
reviewed
Dec 5, 2024
bdice
commented
Dec 8, 2024
vyasr
reviewed
Dec 10, 2024
|
/merge |
rapids-bot
bot
merged commit e16b3a3
into
rapidsai:branch-25.02
104 of 105 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #17523 to use
target_compile_definitionsand drop the Thrust patch.Checklist