Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a minor potential i32 overflow in thrust::transform_exclusive_scan in PQ reader preprocessing #17617

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

mhaseeb123
Copy link
Member

@mhaseeb123 mhaseeb123 commented Dec 17, 2024

Description

This PR fixes a minor potential int32 overflow in thrust::transform_exclusive_scan by setting the init parameter to the correct desired output type (size_t{0}). The counting iterator is also updated size_t type to match pass.chunks.size()'s type, though it's unlikely we will have >2B chunks per pass.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Dec 17, 2024

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 17, 2024
@mhaseeb123 mhaseeb123 added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change cuIO cuIO issue labels Dec 17, 2024
@mhaseeb123 mhaseeb123 changed the title Fix a minor potential integer overflow Fix a minor potential i32 overflow in thrust::transform_exclusive_scan in PQ reader preprocessing Dec 17, 2024
@mhaseeb123 mhaseeb123 marked this pull request as ready for review December 17, 2024 22:06
@mhaseeb123 mhaseeb123 requested a review from a team as a code owner December 17, 2024 22:06
@mhaseeb123 mhaseeb123 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 18, 2024
@mhaseeb123
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit e944f55 into rapidsai:branch-25.02 Dec 18, 2024
105 checks passed
@mhaseeb123 mhaseeb123 deleted the bug-fix-size-type branch December 18, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants