Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove patch that is only needed for clang-tidy to run on test files #17618

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Remove patch that is only needed for clang-tidy to run on test files #17618

merged 1 commit into from
Dec 18, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Dec 17, 2024

Description

We stopped running clang-tidy on test files in #17078 so no reason to carry around these patches anymore.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr requested a review from a team as a code owner December 17, 2024 22:10
@vyasr vyasr self-assigned this Dec 17, 2024
@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 17, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Dec 17, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Dec 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit b096182 into rapidsai:branch-25.02 Dec 18, 2024
107 checks passed
@vyasr vyasr deleted the chore/remove_nanoarrow_patch branch December 18, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees

@vyasr vyasr

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @bdice