Skip to content

Commit

Permalink
fix devcontainer builds (#68)
Browse files Browse the repository at this point in the history
Fixes some small `dependencies.yaml` issues to get devcontainers builds of these libraries working.

Namely:

* wholegraph needs NVML in its build environment
* `pytorch-cuda` should be omitted when building on a CUDA minor version that it doesn't explicitly provide packages for

## Notes for Reviewers

### How I tested this

Pointed rapidsai/devcontainers#417 at this branch and saw it pass.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #68
  • Loading branch information
jameslamb authored Nov 18, 2024
1 parent 16e614c commit e1e32bc
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
1 change: 1 addition & 0 deletions conda/environments/all_cuda-121_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ dependencies:
- breathe
- cmake>=3.26.4,!=3.30.0
- cuda-cudart-dev
- cuda-nvml-dev
- cuda-nvtx-dev
- cuda-profiler-api
- cuda-version=12.1
Expand Down
3 changes: 2 additions & 1 deletion conda/environments/all_cuda-124_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ dependencies:
- breathe
- cmake>=3.26.4,!=3.30.0
- cuda-cudart-dev
- cuda-nvml-dev
- cuda-nvtx-dev
- cuda-profiler-api
- cuda-version=12.4
Expand Down Expand Up @@ -46,7 +47,7 @@ dependencies:
- pytest-cov
- pytest-forked
- pytest-xdist
- pytorch-cuda=12.1
- pytorch-cuda=12.4
- pytorch::pytorch>=2.3,<2.4.0a0
- pytorch_geometric>=2.5,<2.6
- raft-dask==24.12.*,>=0.0.0a0
Expand Down
12 changes: 10 additions & 2 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ dependencies:
cuda: "12.*"
packages:
- cuda-cudart-dev
- cuda-nvml-dev
- cuda-nvtx-dev
- cuda-profiler-api
- libcublas-dev
Expand Down Expand Up @@ -413,12 +414,19 @@ dependencies:
- {matrix: null, packages: [*pytorch_pip, *tensordict]}
- output_types: [conda]
matrices:
- matrix: {cuda: "12.*"}
- matrix: {cuda: "12.1"}
packages:
- pytorch-cuda=12.1
- matrix: {cuda: "11.*"}
- matrix: {cuda: "12.4"}
packages:
- pytorch-cuda=12.4
- matrix: {cuda: "11.8"}
packages:
- pytorch-cuda=11.8
# pytorch only supports certain CUDA versions... skip
# adding pytorch-cuda pinning if any other CUDA version is requested
- matrix:
packages:

depends_on_dgl:
specific:
Expand Down

0 comments on commit e1e32bc

Please sign in to comment.