Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable dask query planning. #5815

Closed
wants to merge 4 commits into from
Closed

Disable dask query planning. #5815

wants to merge 4 commits into from

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 20, 2024

This PR disables dask / dask-expr query planning until some bugs can be fixed.
This is needed to unblock cuml 24.06 CI.

xref: rapidsai/cudf#15027

cc: @rjzamora

@bdice bdice requested review from a team as code owners March 20, 2024 21:48
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue ci labels Mar 20, 2024
@bdice
Copy link
Contributor Author

bdice commented Mar 20, 2024

I looked at some cuml 24.06 CI runs and it seems like there are a lot of failures. This PR disables query planning in cuml so that CI isn't blocked.

CI failure logs 
2024-03-19T20:30:23.6173510Z FAILED test_dask_kmeans.py::test_end_to_end[dataframe-True-None-5-10-1000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6174678Z FAILED test_dask_kmeans.py::test_end_to_end[dataframe-True-None-5-30-1000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6175648Z FAILED test_dask_kmeans.py::test_end_to_end[dataframe-False-None-5-10-1000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6177158Z FAILED test_dask_kmeans.py::test_end_to_end[dataframe-False-None-5-30-1000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6178148Z FAILED test_dask_kmeans.py::test_transform[dataframe-None-1-10-5000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6179166Z FAILED test_dask_kmeans.py::test_transform[dataframe-None-10-10-5000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6180574Z FAILED test_dask_kmeans.py::test_transform[dataframe-None-30-10-5000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6181840Z FAILED test_dask_kmeans.py::test_score[dataframe-None-5-10-1000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6182819Z FAILED test_dask_kmeans.py::test_score[dataframe-None-5-30-1000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6185118Z FAILED test_dask_kneighbors_classifier.py::test_predict_and_score[dataset0-parameters0-dask_cudf] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.
2024-03-19T20:30:23.6187563Z FAILED test_dask_kneighbors_classifier.py::test_predict_and_score[dataset0-parameters1-dask_cudf] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.
2024-03-19T20:30:23.6189580Z FAILED test_dask_kneighbors_classifier.py::test_predict_and_score[dataset0-parameters2-dask_cudf] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.
2024-03-19T20:30:23.6191916Z FAILED test_dask_kneighbors_classifier.py::test_predict_proba[dataset0-parameters0-dask_cudf] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.
2024-03-19T20:30:23.6193986Z FAILED test_dask_kneighbors_classifier.py::test_predict_proba[dataset0-parameters1-dask_cudf] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.
2024-03-19T20:30:23.6196171Z FAILED test_dask_kneighbors_classifier.py::test_predict_proba[dataset0-parameters2-dask_cudf] - ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.
2024-03-19T20:30:23.6197379Z FAILED test_dask_label_encoder.py::test_labelencoder_fit_transform[5-10] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6198262Z FAILED test_dask_label_encoder.py::test_labelencoder_fit_transform[5-1000] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6199218Z FAILED test_dask_label_encoder.py::test_labelencoder_fit_transform[10-10] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6200201Z FAILED test_dask_label_encoder.py::test_labelencoder_fit_transform[10-1000] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6201393Z FAILED test_dask_label_encoder.py::test_labelencoder_fit_transform[50-10] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6202215Z FAILED test_dask_label_encoder.py::test_labelencoder_fit_transform[50-1000] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6203035Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[5-10] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6203818Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[5-100] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6204756Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[5-1000] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6205540Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[10-10] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6206386Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[10-100] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6207179Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[10-1000] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6208331Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[50-10] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6209268Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[50-100] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6210193Z FAILED test_dask_label_encoder.py::test_labelencoder_transform[50-1000] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6211013Z FAILED test_dask_label_encoder.py::test_labelencoder_unseen - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6212062Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label0-ord_label0-expected_reverted0-bad_ord_label0-False] - assert 1 == 4
2024-03-19T20:30:23.6212335Z  +  where 1 = len(0    c\ndtype: object)
2024-03-19T20:30:23.6212680Z  +  and   4 = len(0    c\n1    b\n2    c\n3    a\ndtype: object)
2024-03-19T20:30:23.6213995Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label0-ord_label0-expected_reverted0-bad_ord_label0-True] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6215209Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label1-ord_label1-expected_reverted1-bad_ord_label1-False] - assert 1 == 3
2024-03-19T20:30:23.6215482Z  +  where 1 = len(0    Austin\ndtype: object)
2024-03-19T20:30:23.6215833Z  +  and   3 = len(0    Austin\n1     Tokyo\n2    Austin\ndtype: object)
2024-03-19T20:30:23.6217222Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label1-ord_label1-expected_reverted1-bad_ord_label1-True] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6218164Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label2-ord_label2-expected_reverted2-bad_ord_label2-False] - assert 1 == 2
2024-03-19T20:30:23.6218521Z  +  where 1 = len(0    c1\ndtype: object)
2024-03-19T20:30:23.6218757Z  +  and   2 = len(0    c1\n1     b\ndtype: object)
2024-03-19T20:30:23.6219962Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label2-ord_label2-expected_reverted2-bad_ord_label2-True] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6220895Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label3-ord_label3-expected_reverted3-bad_ord_label3-False] - assert 1 == 4
2024-03-19T20:30:23.6221137Z  +  where 1 = len(0    .09\ndtype: object)
2024-03-19T20:30:23.6221482Z  +  and   4 = len(0     .09\n1    0.09\n2      09\n3    1.09\ndtype: object)
2024-03-19T20:30:23.6222736Z FAILED test_dask_label_encoder.py::test_inverse_transform[orig_label3-ord_label3-expected_reverted3-bad_ord_label3-True] - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6223783Z FAILED test_dask_label_encoder.py::test_empty_input[empty0-ord_label0] - KeyError: 0
2024-03-19T20:30:23.6225280Z FAILED test_dask_label_encoder.py::test_masked_encode - TypeError: data type 'category' not understood
2024-03-19T20:30:23.6227815Z FAILED test_dask_linear_regression.py::test_ols[True-float32-False-False-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6230307Z FAILED test_dask_linear_regression.py::test_ols[True-float32-False-False-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6232831Z FAILED test_dask_linear_regression.py::test_ols[True-float32-False-True-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6234539Z FAILED test_dask_linear_regression.py::test_ols[True-float32-False-True-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6235715Z FAILED test_dask_linear_regression.py::test_ols[True-float64-False-False-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6237150Z FAILED test_dask_linear_regression.py::test_ols[True-float64-False-False-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6238506Z FAILED test_dask_linear_regression.py::test_ols[True-float64-False-True-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6239787Z FAILED test_dask_linear_regression.py::test_ols[True-float64-False-True-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6241046Z FAILED test_dask_linear_regression.py::test_ols[False-float32-False-False-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6242166Z FAILED test_dask_linear_regression.py::test_ols[False-float32-False-False-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6243300Z FAILED test_dask_linear_regression.py::test_ols[False-float32-False-True-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6244839Z FAILED test_dask_linear_regression.py::test_ols[False-float32-False-True-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6247138Z FAILED test_dask_linear_regression.py::test_ols[False-float64-False-False-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6249711Z FAILED test_dask_linear_regression.py::test_ols[False-float64-False-False-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6251957Z FAILED test_dask_linear_regression.py::test_ols[False-float64-False-True-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6254361Z FAILED test_dask_linear_regression.py::test_ols[False-float64-False-True-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6255694Z FAILED test_dask_logistic_regression.py::test_lbfgs_toy[float32-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6256815Z FAILED test_dask_logistic_regression.py::test_lbfgs[True-float32-False-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6257876Z FAILED test_dask_logistic_regression.py::test_lbfgs[True-float32-False-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6259230Z FAILED test_dask_logistic_regression.py::test_lbfgs[True-float32-True-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6260262Z FAILED test_dask_logistic_regression.py::test_lbfgs[True-float32-True-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6261337Z FAILED test_dask_logistic_regression.py::test_lbfgs[False-float32-False-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6262508Z FAILED test_dask_logistic_regression.py::test_lbfgs[False-float32-False-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6263557Z FAILED test_dask_logistic_regression.py::test_lbfgs[False-float32-True-2-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6264630Z FAILED test_dask_logistic_regression.py::test_lbfgs[False-float32-True-23-20-100000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6265749Z FAILED test_dask_logistic_regression.py::test_noreg[False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6267752Z FAILED test_dask_logistic_regression.py::test_noreg[True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6269915Z FAILED test_dask_logistic_regression.py::test_n_classes[8-False-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6272216Z FAILED test_dask_logistic_regression.py::test_n_classes[8-False-23] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6273894Z FAILED test_dask_logistic_regression.py::test_n_classes[8-True-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6275889Z FAILED test_dask_logistic_regression.py::test_n_classes[8-True-23] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6277080Z FAILED test_dask_logistic_regression.py::test_l1[1.0-2-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6278122Z FAILED test_dask_logistic_regression.py::test_l1[1.0-2-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6280456Z FAILED test_dask_logistic_regression.py::test_l1[1.0-8-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6282703Z FAILED test_dask_logistic_regression.py::test_l1[1.0-8-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6284608Z FAILED test_dask_logistic_regression.py::test_l1[10.0-2-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6286455Z FAILED test_dask_logistic_regression.py::test_l1[10.0-2-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6287578Z FAILED test_dask_logistic_regression.py::test_l1[10.0-8-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6288548Z FAILED test_dask_logistic_regression.py::test_l1[10.0-8-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6289613Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.2-2-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6290768Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.2-2-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6291945Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.2-8-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6292921Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.2-8-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6293947Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.8-2-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6294920Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.8-2-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6295966Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.8-8-True-float32-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6297968Z FAILED test_dask_logistic_regression.py::test_elasticnet[0.8-8-True-float32-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6300001Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization0-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6301536Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization0-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6302950Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization1-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6304369Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization1-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6305640Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization2-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6307436Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization2-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6308906Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization3-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6310375Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[2-False-float32-regularization3-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6311762Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization0-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6313227Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization0-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6314576Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization1-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6316174Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization1-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6317504Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization2-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6318936Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization2-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6320657Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization3-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6322041Z FAILED test_dask_logistic_regression.py::test_standardization_on_normal_dataset[8-False-float32-regularization3-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6323462Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization0-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6324869Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization0-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6326453Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization1-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6328086Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization1-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6329786Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization2-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6331112Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization2-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6332399Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization3-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6333823Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses0-False-float32-regularization3-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6335158Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization0-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6336517Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization0-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6338202Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization1-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6339631Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization1-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6341115Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization2-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6342763Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization2-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6344341Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization3-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6345665Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses1-False-float32-regularization3-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6346953Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization0-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6348793Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization0-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6350995Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization1-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6354395Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization1-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6357445Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization2-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6360330Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization2-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6363419Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization3-False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6365008Z FAILED test_dask_logistic_regression.py::test_standardization_on_scaled_dataset[ncol_and_nclasses2-False-float32-regularization3-True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6365546Z FAILED test_dask_one_hot_encoder.py::test_onehot_vs_skonehot - KeyError: 0
2024-03-19T20:30:23.6366245Z FAILED test_dask_one_hot_encoder.py::test_onehot_inverse_transform[None] - KeyError: 0
2024-03-19T20:30:23.6366979Z FAILED test_dask_one_hot_encoder.py::test_onehot_inverse_transform[first] - KeyError: 0
2024-03-19T20:30:23.6367517Z FAILED test_dask_one_hot_encoder.py::test_onehot_inverse_transform[drop2] - KeyError: 0
2024-03-19T20:30:23.6368003Z FAILED test_dask_one_hot_encoder.py::test_onehot_categories - KeyError: 0
2024-03-19T20:30:23.6368536Z FAILED test_dask_one_hot_encoder.py::test_onehot_transform_handle_unknown - KeyError: 0
2024-03-19T20:30:23.6369174Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[10-sparse-cudf-None] - KeyError: 0
2024-03-19T20:30:23.6369858Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[10-sparse-cudf-first] - KeyError: 0
2024-03-19T20:30:23.6370511Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[10-dense-cudf-None] - KeyError: 0
2024-03-19T20:30:23.6371124Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[10-dense-cudf-first] - KeyError: 0
2024-03-19T20:30:23.6371782Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[1000-sparse-cudf-None] - KeyError: 0
2024-03-19T20:30:23.6372393Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[1000-sparse-cudf-first] - KeyError: 0
2024-03-19T20:30:23.6373401Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[1000-dense-cudf-None] - KeyError: 0
2024-03-19T20:30:23.6374075Z FAILED test_dask_one_hot_encoder.py::test_onehot_random_inputs[1000-dense-cudf-first] - KeyError: 0
2024-03-19T20:30:23.6374632Z FAILED test_dask_one_hot_encoder.py::test_onehot_drop_idx_first - KeyError: 0
2024-03-19T20:30:23.6375164Z FAILED test_dask_one_hot_encoder.py::test_onehot_drop_one_of_each - KeyError: 0
2024-03-19T20:30:23.6375711Z FAILED test_dask_ordinal_encoder.py::test_ordinal_encoder_df - KeyError: 0
2024-03-19T20:30:23.6376233Z FAILED test_dask_ordinal_encoder.py::test_handle_unknown[cudf] - KeyError: 0
2024-03-19T20:30:23.6377377Z FAILED test_dask_random_forest.py::test_rf_regression_dask_fil[5-float32] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6378383Z FAILED test_dask_random_forest.py::test_rf_classification_dask_fil_predict_proba[5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6379436Z FAILED test_dask_random_forest.py::test_rf_concatenation_dask[classification] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6380364Z FAILED test_dask_random_forest.py::test_rf_concatenation_dask[regression] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6381233Z FAILED test_dask_random_forest.py::test_single_input_regression[True] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6382536Z FAILED test_dask_random_forest.py::test_single_input_regression[False] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6383464Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-1] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6384612Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6385678Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-3] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6387681Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6388656Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-10] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6389628Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-15] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6390694Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-5-20] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6391911Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-1] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6392889Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6393993Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-3] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6395048Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6397094Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-10] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6399308Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-15] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6401050Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-10-20] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6402798Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-1] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6404490Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6405529Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-3] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6406413Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6407358Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-10] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6408797Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-15] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6410710Z FAILED test_dask_random_forest.py::test_rf_get_json[regression-20-20] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6413434Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-1] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6415570Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6416864Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-3] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6417800Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6418779Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-10] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6419858Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-15] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6420903Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-5-20] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6421837Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-1] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6422961Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6424043Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-3] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6425052Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6426185Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-10] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6427709Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-15] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6429734Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-10-20] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6431914Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-1] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6434200Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-2] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6436118Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-3] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6437617Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-5] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6438543Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-10] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6439560Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-15] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6440461Z FAILED test_dask_random_forest.py::test_rf_get_json[classification-20-20] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6441691Z FAILED test_dask_ridge_regression.py::test_ridge[True-float32-False-False-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6442682Z FAILED test_dask_ridge_regression.py::test_ridge[True-float32-False-False-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6443702Z FAILED test_dask_ridge_regression.py::test_ridge[True-float32-False-True-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6444679Z FAILED test_dask_ridge_regression.py::test_ridge[True-float32-False-True-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6445820Z FAILED test_dask_ridge_regression.py::test_ridge[True-float64-False-False-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6446841Z FAILED test_dask_ridge_regression.py::test_ridge[True-float64-False-False-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6448503Z FAILED test_dask_ridge_regression.py::test_ridge[True-float64-False-True-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6450675Z FAILED test_dask_ridge_regression.py::test_ridge[True-float64-False-True-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6452939Z FAILED test_dask_ridge_regression.py::test_ridge[False-float32-False-False-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6455580Z FAILED test_dask_ridge_regression.py::test_ridge[False-float32-False-False-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6456828Z FAILED test_dask_ridge_regression.py::test_ridge[False-float32-False-True-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6458186Z FAILED test_dask_ridge_regression.py::test_ridge[False-float32-False-True-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6459467Z FAILED test_dask_ridge_regression.py::test_ridge[False-float64-False-False-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6460522Z FAILED test_dask_ridge_regression.py::test_ridge[False-float64-False-False-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6461618Z FAILED test_dask_ridge_regression.py::test_ridge[False-float64-False-True-2-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6462660Z FAILED test_dask_ridge_regression.py::test_ridge[False-float64-False-True-23-10-10000.0] - AttributeError: 'DataFrame' object has no attribute 'dtype'
2024-03-19T20:30:23.6463136Z = 213 failed, 767 passed, 3215 skipped, 36 xfailed, 469 warnings in 3032.61s (0:50:32) =

@bdice bdice mentioned this pull request Mar 20, 2024
Merged
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Mar 20, 2024
@bdice bdice self-assigned this Mar 20, 2024
@bdice bdice changed the base branch from branch-24.04 to branch-24.06 March 20, 2024 22:05
@dantegd
Copy link
Member

dantegd commented Mar 20, 2024

@bdice do you have a link to the 24.06 failures? On a quick look haven't found a PR that has finished jobs in 24.06

@bdice
Copy link
Contributor Author

bdice commented Mar 20, 2024 •
edited
Loading

@dantegd I just reran #5804 CI for this reason! :)

#5804 (comment)

@dantegd
Copy link
Member

dantegd commented Mar 20, 2024

Thanks @bdice! Interestingly, the errors you posted are from the wheels job, from the conda multigpu job intead I see others along the lines of

E           AttributeError: 'Scalar' object has no attribute 'compute_chunk_sizes'

/opt/conda/envs/test/lib/python3.9/site-packages/dask_expr/_collection.py:452: AttributeError

from here: https://github.com/rapidsai/cuml/actions/runs/8347760672/job/22849832453

@bdice
Copy link
Contributor Author

bdice commented Mar 21, 2024 •
edited
Loading

This PR definitely seems to reduce the number of failures. I still see

FAILED experimental/test_filex.py::test_fil_skl_classification[25-RandomForestClassifier-1-native-2-False-30-1000-gpu-gpu] - RuntimeError: exception occurred! file=/__w/cuml/cuml/cpp/include/cuml/experimental/fil/treelite_importer.hpp line=587: base_scores must be identical for all classes
Obtained 63 stack frames
#1 in /pyenv/versions/3.9.19/lib/python3.9/site-packages/cuml/experimental/fil/fil.cpython-39-x86_64-linux-gnu.so: ML::experimental::fil::treelite_importer<(ML::experimental::fil::tree_layout)1>::import(treelite::Model const&, unsigned int, std::optional<bool>, raft_proto::device_type, int, CUstream_st*) +0x1e2 [0x7f254c4f29a2]
#2 in /pyenv/versions/3.9.19/lib/python3.9/site-packages/cuml/experimental/fil/fil.cpython-39-x86_64-linux-gnu.so: ML::experimental::fil::import_from_treelite_model(treelite::Model const&, ML::experimental::fil::tree_layout, unsigned int, std::optional<bool>, raft_proto::device_type, int, CUstream_st*) +0xc3 [0x7f254c4c3733]
#3 in /pyenv/versions/3.9.19/lib/python3.9/site-packages/cuml/experimental/fil/fil.cpython-39-x86_64-linux-gnu.so: ML::experimental::fil::import_from_treelite_handle(void*, ML::experimental::fil::tree_layout, unsigned int, std::optional<bool>, raft_proto::device_type, int, CUstream_st*) +0x13 [0x7f254c4c3823]

All the failures appear to be from test_fil.py and experimental/test_filex.py.

@rjzamora
Copy link
Member

AttributeError: 'Scalar' object has no attribute 'compute_chunk_sizes'

Looks like dask-expr doesn't know how to convert from a Dataframe collection to a dask.array collection when cupy/cupyx is involved. We will need to register these array types with get_collection_type.

I'm sure there are many other issues, but that one shouldn't be too bad.

@rjzamora rjzamora mentioned this pull request Mar 22, 2024
Merged
3 tasks
@github-actions github-actions bot removed conda conda issue Cython / Python Cython or Python issue labels Mar 26, 2024
@rjzamora rjzamora mentioned this pull request Mar 27, 2024
Closed
@vyasr vyasr mentioned this pull request Apr 4, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Apr 5, 2024
@rjzamora
Support implicit array conversion with query-planning enabled (#15378)
0ed224d 
when query-planning is enabled, implicit conversion is not yet supported from a cudf-backed collection to a dask array. [Some cuml + dask CI failures are related to this limitation](rapidsai/cuml#5815 (comment)). This PR adds basic support for implicit conversion.

Authors:
  - Richard (Rick) Zamora (https://github.com/rjzamora)

Approvers:
  - Lawrence Mitchell (https://github.com/wence-)

URL: #15378
@rjzamora
Copy link
Member

rjzamora commented Apr 9, 2024

As an alternative to this PR, #5835 should also unblock CI now.

@bdice
Copy link
Contributor Author

bdice commented Apr 9, 2024

I'll close this since #5835 is a better approach than temporarily disabling tests.

@bdice bdice closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bdice bdice

Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdice @dantegd @rjzamora