Adapt to rmm logger changes #6147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
conda
|
This PR includes a lot of changes that change 24.12 to 25.02 but it targets the 24.12 branch. Is that on purpose/for my education: why? The actual change seems to be https://github.com/rapidsai/cuml/pull/6147/files#diff-1bba462ab050e89360fd88110a689e85ee037749cea091a1848ab574381d3795 which looks reasonable, though most of the CI jobs are unhappy so that needs investigating |
|
This needs to target 25.02, it’s just an oversight. I fixed that and merged the upstream. Hopefully we can fix this today before the Thanksgiving holiday. We are seeing breakage across multiple libraries. |
github-actions
bot
removed
conda
vyasr
commented
Nov 30, 2024
vyasr
added
improvement
KyleFromNVIDIA
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts to breaking changes in rmm in rapidsai/rmm#1722.