-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split up CUDA-suffixed dependencies in dependencies.yaml #247
Conversation
I've updated this based on the suggestions from rapidsai/cudf#16183. Ran the following to check git fetch upstream --tags
ci/release/update-version.sh '24.10.00'
git grep -E '24\.8|24\.08' Did not find any required changes for that script. |
It looks like the
I see the same error on other recent PRs, like #246 (build link), so strongly suspect it's not related to these changes and that this PR would be safe to admin-merge. |
Cancelling CI here (and will on other commits in the next 24 hours) to save some CI capacity for other projects that are about to enter code freeze. |
This will be blocked until #249 is merged. Seeing builds fail like this:
|
/merge |
Contributes to rapidsai/build-planning#31 In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. `cudf` depending on `rmm`, not `rmm-cu12`. This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in `dependencies.yaml`. For more details, see: * rapidsai/build-planning#31 (comment) * rapidsai/cudf#16183 This is targeting 24.08 because: 1. it should be very low-risk 2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08 Authors: - James Lamb (https://github.com/jameslamb) - Paul Taylor (https://github.com/trxcllnt) Approvers: - Bradley Dice (https://github.com/bdice) URL: rapidsai#247
Description
Contributes to rapidsai/build-planning#31
In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g.
cudf
depending onrmm
, notrmm-cu12
.This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in
dependencies.yaml
.For more details, see:
Notes for Reviewers
Why target 24.08?
This is targeting 24.08 because: