Diskann Benchmarking Wrapper #260
Conversation
tarang-jain
added
feature request
…diskann-wrapper
…diskann-wrapper
…diskann-wrapper
…into diskann-wrapper
…into diskann-wrapper
…diskann-wrapper
…diskann-wrapper
…diskann-wrapper
…into vamana-dset-serialize
…into diskann-wrapper
|
/ok to test |
| @@ -32,6 +32,12 @@ option(CUVS_ANN_BENCH_USE_CUVS_BRUTE_FORCE "Include cuVS brute force knn in benc | |||
| option(CUVS_ANN_BENCH_USE_CUVS_CAGRA_HNSWLIB "Include cuVS CAGRA with HNSW search in benchmark" ON) | |||
| option(CUVS_ANN_BENCH_USE_HNSWLIB "Include hnsw algorithm in benchmark" ON) | |||
| option(CUVS_ANN_BENCH_USE_GGNN "Include ggnn algorithm in benchmark" OFF) | |||
| option(CUVS_ANN_BENCH_USE_DISKANN "Include DISKANN search in benchmark" ON) | |||
| option(CUVS_ANN_BENCH_USE_CUVS_VAMANA "Include cuVS Vamana with DiskANN search in benchmark" ON) | |||
| if(CMAKE_SYSTEM_PROCESSOR MATCHES "(ARM|arm|aarch64)") | |||
There was a problem hiding this comment.
Does MSFT DiskANN repo not support ARM?
There was a problem hiding this comment.
Yes, they have mkl-devel as a dependency, which is not meant to be installed in aarch64.
| template <typename T> | ||
| void diskann_ssd<T>::build(const T* dataset, size_t nrow) | ||
| { | ||
| diskann::build_disk_index<float>(base_file_.c_str(), |
There was a problem hiding this comment.
Where is this defined? Is it using the CPU DiskANN repo to build the ssd verson of the index?
There was a problem hiding this comment.
Yes, that is right. It is just to benchmark the CPU build
|
/ok to test |
|
/ok to test |
…into diskann-wrapper
|
/ok to test |
There was a problem hiding this comment.
Please avoid algorithm-specific changes to cpp/bench/ann/src/common/benchmark.hpp as per our offline discussion.
I'm not opposed to exposing dataset/index filepaths to algorithms in general though.
But maybe it would make sense to hide (filter out) them when dumping all build parameters to avoid cluttering the console/reports and exposing private user filepaths?
| void cuvs_vamana<T, IdxT>::search( | ||
| const T* queries, int batch_size, int k, algo_base::index_type* neighbors, float* distances) const | ||
| { | ||
| diskann_memory_search_->search(queries, batch_size, k, neighbors, distances); | ||
| } |
There was a problem hiding this comment.
This doesn't look like this has been addressed yet, right?
(feel free to re-resolve if I'm wrong though)
Brings DiskANN into cuvs-bench