Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Expose extend() in C API #276

Open
wants to merge 94 commits into
base: branch-25.02
Choose a base branch
from

Conversation

ajit283
Copy link
Contributor

@ajit283 ajit283 commented Aug 6, 2024

Add functionality to add additional vectors after build to C API

@ajit283 ajit283 requested a review from a team as a code owner August 6, 2024 15:18
@ajit283 ajit283 requested a review from benfred November 29, 2024 18:53
@cjnolet
Copy link
Member

cjnolet commented Dec 4, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Dec 5, 2024

/ok to test

@ajit283
Copy link
Contributor Author

ajit283 commented Dec 5, 2024

any idea why the style-check failed?

include-check FAILED! See below for errors...
File: cpp/test/neighbors/ann_cagra_c.cu
  Line:18 use #include <...>

I can't see any issue with the include statement

@ajit283 ajit283 changed the base branch from branch-24.12 to branch-25.02 December 7, 2024 13:18
This reverts commit 6edcf93, reversing
changes made to a245fd1.
@cjnolet
Copy link
Member

cjnolet commented Dec 10, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Dec 10, 2024

@ajit283 looks like we have a couple style check failures. Those will need to be fixed to run ci to completion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants