Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.12 into branch-25.02 #522

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

rapids-bot[bot]
Copy link

@rapids-bot rapids-bot bot commented Dec 6, 2024

Forward-merge triggered by push to branch-24.12 that creates a PR to keep branch-25.02 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.

…466)

PR allows calculating ground truth for cuvs-bench on CPU systems. Current version uses a simple NumPy brute force, perhaps we should consider using faiss? cc @cjnolet @divyegala

Authors:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #466
@rapids-bot rapids-bot bot requested review from a team as code owners December 6, 2024 15:42
@rapids-bot rapids-bot bot requested a review from KyleFromNVIDIA December 6, 2024 15:42
@github-actions github-actions bot added the Python label Dec 6, 2024
Copy link
Author

rapids-bot bot commented Dec 6, 2024

FAILURE - Unable to forward-merge due to an error, manual merge is necessary. Do not use the Resolve conflicts option in this PR, follow these instructions https://docs.rapids.ai/maintainers/forward-merger/

IMPORTANT: When merging this PR, do not use the auto-merger (i.e. the /merge comment). Instead, an admin must manually merge by changing the merging strategy to Create a Merge Commit. Otherwise, history will be lost and the branches become incompatible.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.30%. Comparing base (007c3d2) to head (fa8838a).
Report is 32 commits behind head on branch-25.02.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-25.02     #522   +/-   ##
=============================================
  Coverage         72.30%   72.30%           
=============================================
  Files                14       14           
  Lines                65       65           
=============================================
  Hits                 47       47           
  Misses               18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benfred
Copy link
Member

benfred commented Dec 10, 2024

manual forward merge PR is here #526

@benfred benfred mentioned this pull request Dec 10, 2024
@AyodeAwe AyodeAwe merged commit a3b94ec into branch-25.02 Dec 10, 2024
276 of 280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants