Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for python cuvs_bench #541

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

benfred
Copy link
Member

@benfred benfred commented Dec 17, 2024

I'm seeing CI failures due to a missing 'setuptools' on a recent PR https://github.com/rapidsai/cuvs/actions/runs/12363479650/job/34545223389?pr=536 in building the cuvs_bench code.

This seems to be because we were missing some requires in dependencies.yaml. Fix

I'm seeing CI failures due to a missing 'setuptools' on
a recent PR https://github.com/rapidsai/cuvs/actions/runs/12363479650/job/34545223389?pr=536
in building the cuvs_bench code.

This seems to be because we were missing some requires in dependencies.yaml.
Fix
@benfred benfred requested a review from a team as a code owner December 17, 2024 19:42
@benfred benfred requested a review from bdice December 17, 2024 19:42
@benfred benfred added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 17, 2024
@github-actions github-actions bot added Python and removed improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 17, 2024
@benfred benfred self-assigned this Dec 17, 2024
@benfred benfred added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Dec 17, 2024
@bdice
Copy link
Contributor

bdice commented Dec 17, 2024

This seems not quite right. I’ll have a closer look.

@bdice
Copy link
Contributor

bdice commented Dec 17, 2024

The CI failure says:

ValueError: Could not import build backend specified in pyproject.toml's tool.rapids-build-backend table. Make sure you specified the right optional dependency in your build-system.requires entry for rapids-build-backend.

but we already specified that here, I think?

@bdice
Copy link
Contributor

bdice commented Dec 17, 2024

Aha. This occurs in conda package builds, so the dependencies.yaml / pyproject.toml are not used (conda builds call build.sh which uses --no-build-isolation --no-deps). This is occurring because we are missing setuptools in conda/recipes/cuvs-bench/meta.yaml. The proper fix should be the same as this PR from earlier today: rapidsai/dask-cuda#1418

@benfred
Copy link
Member Author

benfred commented Dec 17, 2024

Ahh - thanks @bdice ! Thats a great find - I've applied the same fix in the last commit

@benfred
Copy link
Member Author

benfred commented Dec 18, 2024

/merge

@rapids-bot rapids-bot bot merged commit b3ce774 into rapidsai:branch-25.02 Dec 18, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants