-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI for python cuvs_bench #541
Fix CI for python cuvs_bench #541
Conversation
I'm seeing CI failures due to a missing 'setuptools' on a recent PR https://github.com/rapidsai/cuvs/actions/runs/12363479650/job/34545223389?pr=536 in building the cuvs_bench code. This seems to be because we were missing some requires in dependencies.yaml. Fix
This seems not quite right. I’ll have a closer look. |
The CI failure says:
but we already specified that here, I think? cuvs/python/cuvs_bench/pyproject.toml Line 7 in b859bc5
|
Aha. This occurs in conda package builds, so the |
This reverts commit 03bd23a.
Ahh - thanks @bdice ! Thats a great find - I've applied the same fix in the last commit |
/merge |
I'm seeing CI failures due to a missing 'setuptools' on a recent PR https://github.com/rapidsai/cuvs/actions/runs/12363479650/job/34545223389?pr=536 in building the cuvs_bench code.
This seems to be because we were missing some requires in dependencies.yaml. Fix