Additional Distances for CAGRA C and Python API #546
+24
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarang-jain
added
C
Python
non-breaking
divyegala
reviewed
Dec 19, 2024
| # self.params.metric = _get_metric(metric) | ||
| # self.params.metric_arg = 0 | ||
| self._metric = metric | ||
| self.params.metric = <cuvsDistanceType>DISTANCE_TYPES[metric] |
There was a problem hiding this comment.
Can you check if the dictionary has an entry for "sqeuclidean" and not "euclidean"? I'm not sure how the tests were working until now.
There was a problem hiding this comment.
The tests until now were using the L2Expanded metric for CAGRA irrespective of what was being passed as the metric. "sqeuclidean" translates to L2Expanded and "euclidean" translates to L2SqrtExpanded. The min recall bound in the pytests so far was quite low (=0.7) which is why even if the groundtruth was created using inner product, the tests were passing. I've checked precisely what cuvs distance type is being dispatched to the C++ level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InnerProduct metric to CAGRA C and Python API + updates to CAGRA pytests.
Closes #545