Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin py-xgboost in dask-sql CI #87

Closed
wants to merge 1 commit into from
Closed

Unpin py-xgboost in dask-sql CI #87

wants to merge 1 commit into from

Conversation

charlesbluca
Copy link
Member

This unblocks the build failures that result from the addition of py-xgboost=1.7.0 to dask-sql's 3.9 environment in dask-contrib/dask-sql#1301.

@jakirkham
Copy link
Member

Could we move to XGBoost 2?

This was referenced Mar 14, 2024
Closed
Merged
@charlesbluca
Copy link
Member Author

I think so, testing this out against CI here: dask-contrib/dask-sql#1314

If things pass there can go ahead and merge and close this

@jakirkham
Copy link
Member

Looks like things passed for Dask-SQL based on Charles' testing. Approving

@charlesbluca
Copy link
Member Author

Thanks @jakirkham! I'm going to retry the dask-sql builds locally to see if dask-contrib/dask-sql#1314 unblocks things, if so should be good to close this

@jakirkham
Copy link
Member

Certainly merge at your discretion 🙂

@charlesbluca
Copy link
Member Author

Verified that with dask-contrib/dask-sql#1314 and #88, builds should be unblocked - closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbluca @jakirkham