-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rapids-build-backend #1343
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-24.08
from
jameslamb:rapids-build-backend
Jun 10, 2024
Merged
use rapids-build-backend #1343
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c9fffe5
use rapids-build-backend
jameslamb a81532a
include setuptools in build-system table
jameslamb 10bee82
add commit-file
jameslamb a8297b4
commit-files
jameslamb dc68abb
move kvikio around
jameslamb b1bd6e9
put distributex-ucxx back in conda envs
jameslamb 4c6c40f
remove kvikio from CUDA-version-specific matrices
jameslamb 7897bea
commit-files is unnecessary
jameslamb b054f02
Merge branch 'branch-24.08' into rapids-build-backend
jameslamb d05bb9c
Merge branch 'branch-24.08' into rapids-build-backend
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# Copyright (c) 2024, NVIDIA CORPORATION. | ||
|
||
import dask_cuda | ||
|
||
|
||
def test_version_constants_are_populated(): | ||
# __git_commit__ will only be non-empty in a built distribution | ||
assert isinstance(dask_cuda.__git_commit__, str) | ||
|
||
# __version__ should always be non-empty | ||
assert isinstance(dask_cuda.__version__, str) | ||
assert len(dask_cuda.__version__) > 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dependencies.yaml
here is being used to populate a[test]
extra inpyproject.toml
that is not ever actually used (as far as I can tell).I've documented the (I think separate) work to set up wheel tests at some point in #1344.
For purposes of this PR, I chose to:
rapids-build-backend
will choose the suffixed ones when populating thetest
extra on the wheels it produces)kvikio
for the CUDA-version-specific cases forpyproject
/requirements
, as it doesn't currently have wheels (add wheel output kvikio#369)Because this is being built with
disable-cuda=true
, the wheels built byrapids-build-backend
will continue to have unsuffixed dependencies and includekvikio
.But at least breaking out the matrices like this means that other uses of
rapids-dependency-file-generator
to generate CUDA-specific requirements for this repo would get the-cu{major}
suffixed versions.