Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always test pynvml #1421

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Always test pynvml #1421

merged 1 commit into from
Dec 20, 2024

Conversation

pentschev
Copy link
Member

Do not skip pynvml if it's not importable, given pynvml is a hard-dependency.

@pentschev pentschev added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 20, 2024
@pentschev pentschev requested a review from a team as a code owner December 20, 2024 20:02
@github-actions github-actions bot added the python python code needed label Dec 20, 2024
@jakirkham jakirkham requested a review from jameslamb December 20, 2024 20:20
jakirkham
jakirkham approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter! 🙏

@jakirkham jakirkham mentioned this pull request Dec 20, 2024
Merged
@jameslamb
Copy link
Member

Seeing test jobs pass and no concerning warnings in CI logs, queuing this to auto-merge.

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 98f57ee into rapidsai:branch-25.02 Dec 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @jameslamb @jakirkham