-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA to mark issues/prs as stale/rotten #525
Conversation
Issues and PRs without activity for 30d will be marked as stale. If there is no activity for 90d, they will be marked as rotten. Signed-off-by: Jordan Jacobelli <[email protected]>
Currently it's for all PRs. I think we should keep it this way to be sure we do not leave PRs as "blocked" despite the blocking condition is resolved. You will just need to comment the PR to remove the |
I wouldn't mind doing that every 90 days or so, but these PRs may be there easily for 6+ months, as is the case of #326 , where we're blocked by a Dask feature that's currently on hold. Doing so every 30 days feels a bit annoying, that would mean we will end up having to do this roughly twice for every RAPIDS release. |
Alternatively, could this changed only PRs that aren't marked as "Draft"? I think that would be a reasonable middle ground. |
Hey @pentschev, I understand your point, but the idea here is to be able to track issues and PRs without activity. Ignoring some PRs/issues would be contrary to the objective. We want to be sure we are not letting any issue or PR open without reason and so by commenting every month, we are sure the blocking condition is evaluated again. WDYT? |
Honestly, I think this is going to be a big annoyance, I would prefer if we could have a way to add exceptions to some PRs, even if it's just a label or something that would allow us a longer grace period for those marked in such a way. |
Maybe we can create a specific label to ignore some PRs/issues |
@pentschev @madsbk I understand your position and agree it will add a few minutes to update these PRs monthly even to say Feedback from @aravenel and @fondaing is that an issue/PR with several |
Using this PR to resolve auto-merger issue: #528 |
Issues and PRs without activity for 30d will be marked as stale.
If there is no activity for 90d, they will be marked as rotten.