Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): require python-build in conda recipe #107

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 28, 2024

I saw conda builds in CI on #106 failing like this:

Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
 - python >=3.9
 - build

with channels:

The reported errors are:
- Encountered problems while solving:
-   - nothing provides requested build

Looks to me like this is due to the following set of circumstances:

This fixes that by switching the dependency in the recipe from build to python-build.

Notes for Reviewers

I'm really not sure why this is just breaking now... the latest release of build at https://anaconda.org/conda-forge/build/files is a noarch package without any constraints that appear to conflict with other things we're installing here.

python-build is what we want either way, since it's being actively updated, but would be good to understand why this just broke now.

I checked across the rapidsai org and don't see any other cases where we were relying on the old build package: https://github.com/search?q=org%3Arapidsai+%22-+build%22+language%3AYAML+path%3Ameta.yaml&type=code

@vyasr
Copy link
Contributor

vyasr commented Aug 29, 2024

Perhaps a Python version upper bound somewhere, combined with an upgrade to our containers? The original package seems like it's a noarch package, though.

@jameslamb jameslamb merged commit a08bc55 into rapidsai:main Aug 29, 2024
5 checks passed
@jameslamb jameslamb deleted the fix/recipe branch August 29, 2024 13:40
@GPUtester
Copy link

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants