fix: support rendering nested pyproject.toml outputs to stdout #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85.
Contributes to rapidsai/build-planning#31 (via making debugging those changes easier).
#85 contains a reproducible example and details of the problem this solves. In short:
dependency-file-generator
currently defaults to looking for the file to overwrite in the current working directory./pyproject.toml
as the source for an invocation that should be handling e.g../python/cudf/pyproject.toml
This proposes the following:
make_dependency_files()
to alwaysconda_dir
/pyproject_dir
/requirements_dir
as a source of the file to load / possibly overwriteget_output_dir()
docstringget_output_dir()
to use keyword-only argumentsNotes for Reviewers
How I tested this
Installed the version from
main
on this branch.git checkout main -- src/rapids_dependency_file_generator/_rapids_dependency_file_generator.py pip install --ignore-installed .
Confirmed that this new unit test fails on
main
, and is reading in the root-levelpyproject.toml
instead of the nested one.Confirmed that it fails with the same error as #85 on the new test project added here.
Tested on
cudf
's actualdependencies.yaml
onbranch-24.06
.rapids-dependency-file-generator \ --output pyproject \ --file-key py_run_cudf \ --matrix "cuda=12.2"