Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to the manifest #422

Merged
merged 11 commits into from
Dec 2, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 18, 2024

This PR fixes a number of issues in the manifest:

@vyasr vyasr requested a review from a team as a code owner November 18, 2024 23:05
@vyasr vyasr requested review from AyodeAwe and removed request for a team November 18, 2024 23:05
@vyasr vyasr self-assigned this Nov 18, 2024
@trxcllnt
Copy link
Collaborator

@vyasr cudf's dependency on rmm was accidentally removed

It wasn't removed, instead the scripts added a feature to include dependencies recursively. So if cudf depends on kvikio, and kvikio depends on rmm, then cudf gets both -Drmm_ROOT= -Dkvikio_ROOT=.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 20, 2024

@vyasr cudf's dependency on rmm was accidentally removed

It wasn't removed, instead the scripts added a feature to include dependencies recursively. So if cudf depends on kvikio, and kvikio depends on rmm, then cudf gets both -Drmm_ROOT= -Dkvikio_ROOT=.

That seems like a good thing to do but also error-prone to rely on exclusively. I would rather follow a similar practice to how you would handle Python dependencies, C++ includes, or Python imports: if you only use something transitively then the recursive solution is good, but if you use something directly you should still include it. Otherwise you could wind up needing to make nonlocal (e.g. if raft removes a dependency that cugraph needs you'd have to trace that) or seemingly unrelated (when we remove cugraph-ops as a dependency of cugraph here, we lose every dependency of cugraph) changes.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 20, 2024

Note that in this case what happened was that #414 removed the rmm dependency from kvikio because it does not in fact depend on rmm, but I didn't realize that was going to impact cudf.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 22, 2024

@trxcllnt what do you want to do with this PR?

Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this needs to be name: pylibwholegraph:

    - name: wholegraph
      sub_dir: python/pylibwholegraph

@bdice
Copy link
Contributor

bdice commented Nov 26, 2024

Pretty sure this needs to be name: pylibwholegraph:

    - name: wholegraph
      sub_dir: python/pylibwholegraph

Agreed. I updated this in e140cff.

@vyasr
Copy link
Contributor Author

vyasr commented Nov 26, 2024

Yup that's a good change (although effectively superfluous now that wholegraph is deprecated and the repo is archived, but we can remove it in a future changeset).

@vyasr vyasr requested a review from trxcllnt November 26, 2024 20:37
@bdice
Copy link
Contributor

bdice commented Nov 26, 2024

Yup that's a good change (although effectively superfluous now that wholegraph is deprecated and the repo is archived, but we can remove it in a future changeset).

It's still a library -- it just exists in the cugraph-gnn repo. This entry for pylibwholegraph is in the cugraph-gnn repo, its new home.

@trxcllnt
Copy link
Collaborator

trxcllnt commented Nov 26, 2024

We'll need to backport the wholegraph -> pylibwholegraph fix to the 24.12 branch, because it looks like the move happened in that release.

(edit: done in #427)

@trxcllnt
Copy link
Collaborator

Curious that this PR seems to lead to missing symbol issues...

@bdice
Copy link
Contributor

bdice commented Nov 27, 2024

@trxcllnt It’s not this PR, it’s an upstream issue caused by breaking changes in rapidsai/rmm#1722

cc: @vyasr

@vyasr
Copy link
Contributor Author

vyasr commented Dec 2, 2024

All right, I think all of the necessary upstream changes have been merged. I'm rerunning CI, things should pass this time around.

@vyasr vyasr merged commit 0acd9ac into rapidsai:branch-25.02 Dec 2, 2024
26 checks passed
@vyasr vyasr deleted the fix/manifest_changes branch December 2, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants