-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes to the manifest #422
Conversation
It wasn't removed, instead the scripts added a feature to include dependencies recursively. So if cudf depends on kvikio, and kvikio depends on rmm, then cudf gets both |
That seems like a good thing to do but also error-prone to rely on exclusively. I would rather follow a similar practice to how you would handle Python dependencies, C++ includes, or Python imports: if you only use something transitively then the recursive solution is good, but if you use something directly you should still include it. Otherwise you could wind up needing to make nonlocal (e.g. if raft removes a dependency that cugraph needs you'd have to trace that) or seemingly unrelated (when we remove cugraph-ops as a dependency of cugraph here, we lose every dependency of cugraph) changes. |
Note that in this case what happened was that #414 removed the rmm dependency from kvikio because it does not in fact depend on rmm, but I didn't realize that was going to impact cudf. |
@trxcllnt what do you want to do with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this needs to be name: pylibwholegraph
:
- name: wholegraph
sub_dir: python/pylibwholegraph
Agreed. I updated this in e140cff. |
Yup that's a good change (although effectively superfluous now that wholegraph is deprecated and the repo is archived, but we can remove it in a future changeset). |
It's still a library -- it just exists in the cugraph-gnn repo. This entry for |
We'll need to backport the (edit: done in #427) |
Curious that this PR seems to lead to missing symbol issues... |
@trxcllnt It’s not this PR, it’s an upstream issue caused by breaking changes in rapidsai/rmm#1722 cc: @vyasr |
All right, I think all of the necessary upstream changes have been merged. I'm rerunning CI, things should pass this time around. |
This PR fixes a number of issues in the manifest:
devcontainer-utils
andrapids-build-utils
updates for DLFW #221. Since rmm is header-only I guess nobody noticed the issue since it doesn't increase build times and only shows up if you attempt to make local changes to rmm and test them in cudf.-D<package_name>_ROOT
variables in the CMake configure don't cause any problems so I made everything explicit.