Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CI matrix from shared-workflows #22

Merged
merged 16 commits into from
May 8, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

#21 restored Python 3.9 support, but used hard-coded CI images. Use https://github.com/rapidsai/shared-workflows to select an appropriate CI image.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners May 3, 2024 20:21
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This has some advantages like removing the need for a separate upload command.

.github/workflows/checks-and-builds.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Let’s merge this and use RBB packages in downstream PRs.

@KyleFromNVIDIA KyleFromNVIDIA merged commit 06bdbc3 into rapidsai:main May 8, 2024
7 checks passed
KyleFromNVIDIA added a commit to KyleFromNVIDIA/rapids-build-backend that referenced this pull request May 8, 2024
rapidsai#22 changed
how the package is uploaded to S3, but did not include
RAPIDS_PY_WHEEL_NAME.
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request May 8, 2024
KyleFromNVIDIA added a commit that referenced this pull request May 9, 2024
#22 changed how the
package is uploaded to S3, but did not include `RAPIDS_PY_WHEEL_NAME`.
Fix uploading, and also don't publish the `main` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants