remove require_cuda defaults in internal functions #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31.
This project attempts to determine the version of CUDA present on the system using
nvcc
. By default, if that attempt fails it raises an exception.This is configurable from the public API of the build backend, like this in
pyproject.toml
...rapids-build-backend/README.md
Line 25 in 0c7e6d1
This PR proposes removing defaults in the signatures of internal functions that perform implement that behavior, to reduce the risk of "oops forgot to pass this through and
rapids-build-backend
silently fell back to some a default" types of bugs.In my opinion, it'd be useful to restrict knowledge of default values for configuration to exactly one place... the code used to parse configuration.
rapids-build-backend/rapids_build_backend/config.py
Lines 26 to 37 in 0c7e6d1
And in general, for there to be as few competing sources of configuration values as possible.
How I tested this
Looked for all uses like this.
Otherwise, relying on this project's
pre-commit
+ CI.