Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning when dependencies.yaml doesn't exist #35

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix warning when dependencies.yaml doesn't exist #35

merged 1 commit into from
May 17, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

The warning was accidentally being issued with a tuple instead of a string. Fix.

@KyleFromNVIDIA
Fix warning when dependencies.yaml doesn't exist
794f21d 
The warning was accidentally being issued with a tuple instead of
a string. Fix.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner May 17, 2024 18:40
jameslamb
jameslamb approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blegh thank you for fixing this! Sorry I didn't write a test case for it in #33 .

@jameslamb jameslamb added bug Something isn't working non-breaking Introduces a non-breaking change labels May 17, 2024
@KyleFromNVIDIA KyleFromNVIDIA merged commit ca51a32 into rapidsai:main May 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleFromNVIDIA @jameslamb