Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor dependency-file-generator handling of cupy, default to CUDA 12 in fallback dependency lists #1059

Merged
merged 2 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ build:
python: "mambaforge-22.9"
jobs:
post_create_environment:
# explicitly passing matrix-entry so that 'libucx' is pulled in,
# and therefore tested in this no-CUDA environment
# explicitly passing matrix-entry so that 'libucx' (with appropriate CUDA suffix)
# is pulled in, and therefore tested in this no-CUDA environment
- |
pip install \
-C rapidsai.matrix-entry="cuda=12.2;cuda_suffixed=true" \
-C rapidsai.matrix-entry="cuda=12.x;cuda_suffixed=true" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😄

.

conda:
Expand Down
41 changes: 21 additions & 20 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ files:
- checks
- cuda
- cuda_version
- depends_on_cupy
- py_version
- rapids_build_setuptools
- run
Expand All @@ -14,6 +15,7 @@ files:
output: none
includes:
- cuda_version
- depends_on_cupy
- py_version
- test_python
checks:
Expand Down Expand Up @@ -52,6 +54,7 @@ files:
table: project.optional-dependencies
key: test
includes:
- depends_on_cupy
- test_python
channels:
- rapidsai
Expand Down Expand Up @@ -135,6 +138,24 @@ dependencies:
packages:
- numpy>=1.23,<2.0a0
- pynvml>=11.4.1
depends_on_cupy:
common:
- output_types: conda
packages:
- cupy>=12.0.0
# NOTE: This is intentionally not broken into groups by a 'cuda_suffixed' selector like
# other packages with -cu{nn}x suffixes in this file.
# All RAPIDS wheel builds (including in devcontainers) expect cupy to be suffixed.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is exactly the language I'm proposing over in rapidsai/cugraph#4552 (comment) as well

specific:
- output_types: [requirements, pyproject]
matrices:
- matrix: {cuda: "12.*"}
packages:
- &cupy_cu12 cupy-cuda12x>=12.0.0
- matrix: {cuda: "11.*"}
packages:
- cupy-cuda11x>=12.0.0
- {matrix: null, packages: [*cupy_cu12]}
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
depends_on_ucx_build:
common:
- output_types: conda
Expand Down Expand Up @@ -205,7 +226,6 @@ dependencies:
- output_types: [conda]
packages:
- &cudf_unsuffixed cudf==24.10.*,>=0.0.0a0
- cupy>=12.0.0
specific:
- output_types: [requirements, pyproject]
matrices:
Expand All @@ -214,30 +234,11 @@ dependencies:
cuda_suffixed: "true"
packages:
- cudf-cu12==24.10.*,>=0.0.0a0
- &cupy_cu12 cupy-cuda12x>=12.0.0
- matrix:
cuda: "12.*"
cuda_suffixed: "false"
packages:
- *cudf_unsuffixed
# NOTE: cupy still has a "-cuda12x" suffix here, because it's suffixed
# in DLFW builds
- *cupy_cu12
- matrix:
cuda: "11.*"
cuda_suffixed: "true"
packages:
- cudf-cu11==24.10.*,>=0.0.0a0
- &cupy_cu11 cupy-cuda11x>=12.0.0
- matrix:
cuda: "11.*"
cuda_suffixed: "false"
packages:
- *cudf_unsuffixed
# NOTE: cupy still has a "-cuda11x" suffix here, because it's suffixed
# in DLFW builds
- *cupy_cu11
- matrix:
packages:
- *cudf_unsuffixed
- *cupy_cu11
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ classifiers = [
test = [
"cloudpickle",
"cudf==24.10.*,>=0.0.0a0",
"cupy-cuda11x>=12.0.0",
"cupy-cuda12x>=12.0.0",
"dask",
"distributed",
"numba>=0.57",
Expand Down