Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require approval to run CI on draft PRs #1096

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 26, 2024

By default, CI runs on draft PRs. This leads to many CI runs that may be unnecessary.

With this PR's change to .github/copy-pr-bot.yaml, an /ok to test comment from a trusted user is required to trigger CI on draft PRs. Non-draft PRs will run CI by default, assuming that all commits are signed by trusted users. Otherwise an /ok to test is required (as before) -- see the copy-pr-bot docs at https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/ for more information.

Part of rapidsai/build-planning#123.

@bdice bdice requested a review from a team as a code owner November 26, 2024 19:01
@bdice bdice requested a review from msarahan November 26, 2024 19:01
@jameslamb jameslamb removed the request for review from msarahan November 26, 2024 20:06
@bdice
Copy link
Contributor Author

bdice commented Nov 26, 2024

ERROR test_custom_send_recv.py - ValueError: pylibcudf.io.types.ColumnInMetadata size changed, may indicate binary incompatibility. Expected 112 from C header, got 48 from PyObject

This failure is likely temporary and should be resolved by new pylibcudf package builds. I'll request an admin-merge on this for now.

@raydouglass raydouglass merged commit 80493c9 into rapidsai:branch-0.42 Nov 26, 2024
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants