Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to rmm logger changes #336

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 26, 2024

This PR adapts to breaking changes in rmm in rapidsai/rmm#1722.

@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 26, 2024
@vyasr vyasr self-assigned this Nov 26, 2024
@vyasr vyasr requested a review from a team as a code owner November 26, 2024 19:18
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from KyleFromNVIDIA November 26, 2024 20:25
@vyasr vyasr requested a review from a team as a code owner November 27, 2024 01:48
@vyasr vyasr added the DO NOT MERGE Hold off on merging; see PR for details label Nov 27, 2024
ci/build_cpp.sh Outdated Show resolved Hide resolved
@vyasr vyasr removed the DO NOT MERGE Hold off on merging; see PR for details label Nov 27, 2024
@vyasr vyasr requested review from pentschev and removed request for a team November 27, 2024 15:37
@vyasr
Copy link
Contributor Author

vyasr commented Nov 27, 2024

/merge

@rapids-bot rapids-bot bot merged commit be0965b into rapidsai:branch-0.42 Nov 27, 2024
69 of 75 checks passed
@vyasr vyasr deleted the feat/rmm_logger branch November 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants