Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32 bit mode reading long in readInt syscall #101

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

DvvCz
Copy link

@DvvCz DvvCz commented Nov 29, 2024

Fixes #93

Let me know if you'd rather have the readLong/readInt deduplicated, or fixed in another way.

Tested with the given reproduction case in the issue:

li a7, 5
ecall
li a7, 1
ecall
mv a0, a0
ecall

Throws error on 32 bit, prints identical number twice on 64 as expected.

@privat
Copy link
Collaborator

privat commented Nov 29, 2024

Thank you!

Copy link

Test Results

12 files  ±0  12 suites  ±0   36s ⏱️ ±0s
 8 tests ±0   8 ✅ ±0  0 💤 ±0  0 ❌ ±0 
24 runs  ±0  24 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4716fa4. ± Comparison against base commit b0cb517.

@privat privat merged commit ef563eb into rarsm:master Nov 29, 2024
6 checks passed
@DvvCz DvvCz deleted the syscall-readint-32 branch November 29, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syscall readInt always reads 64 bit numbers
2 participants