Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight read #34

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Highlight read #34

merged 9 commits into from
Jul 4, 2024

Conversation

Shin-703
Copy link

@Shin-703 Shin-703 commented Jul 2, 2024

This is an answer to the issue #7 highlight read. This enhancement adds highlights when explicitly reading data (in data segment or register block) while executing step by step.

There is now two colors for these highlights (configurable by the user), blue for explicit reading and redish for explicit writing.

@privat
Copy link
Collaborator

privat commented Jul 3, 2024

There are some errors on my machine, maybe some settings are not initialized properly

$ java -jar rars.jar 
Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot invoke "java.awt.Color.equals(Object)" because "<local3>" is null
	at rars.venus.settings.SettingsHighlightingAction.initializeButtonColors(SettingsHighlightingAction.java:341)
	at rars.venus.settings.SettingsHighlightingAction.buildDialogPanel(SettingsHighlightingAction.java:175)

@privat
Copy link
Collaborator

privat commented Jul 3, 2024

it works \o/ :tada:

src/rars/venus/registers/RegisterBlockWindow.java Outdated Show resolved Hide resolved
src/rars/venus/DataSegmentWindow.java Outdated Show resolved Hide resolved
@privat privat merged commit 076efeb into rarsm:master Jul 4, 2024
1 check passed
@DvvCz DvvCz mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants