label coloring for jumps #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privat
reviewed
Jul 4, 2024
| private void findLabelKeywords() { | ||
| labelKeywords = new KeywordMap(false); | ||
| if (Globals.getGui().getMainPane().getEditPane() != null) { | ||
| char[] array = Globals.getGui().getMainPane().getEditPane().getSource().toCharArray(); |
There was a problem hiding this comment.
The way you get the source code seems to break a lot of isolation and separation of concern.
| for (char c : array) { | ||
| if (c == '\n') | ||
| lastNewLine = currentIndex; | ||
| if (c == ':') { |
There was a problem hiding this comment.
There are already 2 tokenizers (rars.assembler.Tokenizer and rars.venus.editors.jeditsyntax.tokenmarker) ; there should be a way to reuse one of them or generalize it instead of parsing the label definition a 3rd way.
Ideally, there should be only one tokenizers, but that's another battle :)
| @@ -73,6 +73,7 @@ public static String[] getRISCVTokenExamples() { | |||
|
|
|||
|
|
|||
| public byte markTokensImpl(byte token, Segment line, int lineIndex) { | |||
| findLabelKeywords(); | |||
There was a problem hiding this comment.
markTokensImpl seems to be called a lot. I'm not sure what is its job.
Merged
privat
added a commit
that referenced
this pull request
Jul 15, 2024
This is an alternative implementation of #35 Instead of rescaning the document on each markTokensImpl, a special update method is called on each document modification. The KeywordMap class is also extended to handle the clearing of all keywords.
|
Superseded by #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an enhancement for the edit pane: adding color to labels.
We are here adding coloring to labels when they appear in the file without the ':'. If the label has already been placed with ':' somewhere in the file, we color the corresponding label every time it is used (in a branching situation for example). It will be colored as soon as the label is placed with ':', and uncolored if that part gets erased.
This is a way to see typos immediately when coding : if there is a typo in the label, it will not be colored. With this, you don't have to wait until you assemble to see that you have typos in your labels. The enhancement also allows better visibility of labels, which are not just plain text.