Allow openocd build to fail

raspberrypi · Aug 30, 2024 · 8299c6b · 8299c6b
1 parent c4355a7
commit 8299c6b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 20 deletions.
diff --git a/build_linux.sh b/build_linux.sh
@@ -4,13 +4,7 @@ set -euo pipefail
 
 # Defaults
 SKIP_RISCV=${SKIP_RISCV-0}
-if git clone https://git.savannah.nongnu.org/git/git2cl.git; then
-    SKIP_OPENOCD=${SKIP_OPENOCD-0}
-else
-    # Clone is failing, so skip build
-    echo "Skipping openocd build, as likely to fail"
-    SKIP_OPENOCD=${SKIP_OPENOCD-1}
-fi
+SKIP_OPENOCD=${SKIP_OPENOCD-0}
 
 # Install prerequisites
 sudo apt install -y jq cmake libtool automake libusb-1.0-0-dev libhidapi-dev libftdi1-dev
@@ -42,13 +36,16 @@ done < <(echo "$repos")
 
 
 cd $builddir
+if [[ "$SKIP_OPENOCD" != 1 ]]; then
+    if ../packages/linux/openocd/build-openocd.sh; then
+        echo "OpenOCD Build failed"
+        SKIP_OPENOCD=1
+    fi
+fi
 if [[ "$SKIP_RISCV" != 1 ]]; then
     # Takes ages to build
     ../packages/linux/riscv/build-riscv-gcc.sh
 fi
-if [[ "$SKIP_OPENOCD" != 1 ]]; then
-    ../packages/linux/openocd/build-openocd.sh
-fi
 ../packages/linux/picotool/build-picotool.sh
 cd ..
 

diff --git a/build_macos.sh b/build_macos.sh
@@ -4,13 +4,7 @@ set -euo pipefail
 
 # Defaults
 SKIP_RISCV=${SKIP_RISCV-0}
-if git clone https://git.savannah.nongnu.org/git/git2cl.git; then
-    SKIP_OPENOCD=${SKIP_OPENOCD-0}
-else
-    # Clone is failing, so skip build
-    echo "Skipping openocd build, as likely to fail"
-    SKIP_OPENOCD=${SKIP_OPENOCD-1}
-fi
+SKIP_OPENOCD=${SKIP_OPENOCD-0}
 
 # Install prerequisites
 arch -x86_64 /usr/local/bin/brew install jq libtool libusb automake hidapi
@@ -53,13 +47,16 @@ done < <(echo "$repos")
 
 
 cd $builddir
+if [[ "$SKIP_OPENOCD" != 1 ]] && [[ $(uname -m) == 'arm64' ]]; then
+    if ../packages/macos/openocd/build-openocd.sh; then
+        echo "OpenOCD Build failed"
+        SKIP_OPENOCD=1
+    fi
+fi
 if [[ "$SKIP_RISCV" != 1 ]]; then
     # Takes ages to build
     ../packages/macos/riscv/build-riscv-gcc.sh
 fi
-if [[ "$SKIP_OPENOCD" != 1 ]] && [[ $(uname -m) == 'arm64' ]]; then
-    ../packages/macos/openocd/build-openocd.sh
-fi
 arch -x86_64 ../packages/macos/picotool/build-picotool.sh
 arch -arm64 ../packages/macos/picotool/build-picotool.sh
 ../packages/macos/picotool/merge-picotool.sh