Allow using thirdparty VID for reboot interface #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnAZoidberg
added a commit
to FrameworkComputer/inputmodule-rs
that referenced
this pull request
Nov 17, 2024
Depends on: raspberrypi/picotool#177 Signed-off-by: Daniel Schaefer <[email protected]>
2 tasks
|
Could you rebase this and target it at the develop branch instead of master? |
JohnAZoidberg
force-pushed
the
thirdparty-stdio_usb
branch
from
701283f
to
5788b3b
Compare
@will-v-pi sure, done! |
will-v-pi
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks, that looks good and I've checked it works for me too
Could you fix the Bazel build and then we can merge this (@armandomontanez can hopefully help with that if needed)?
|
The Bazel fix is fortunately trivial: diff --git a/picoboot_connection/BUILD.bazel b/picoboot_connection/BUILD.bazel
index fd8b15b..b2fac4d 100644
--- a/picoboot_connection/BUILD.bazel
+++ b/picoboot_connection/BUILD.bazel
@@ -19,5 +19,6 @@ cc_library(
"@pico-sdk//src/common/boot_picoboot_headers",
"@pico-sdk//src/rp2_common/boot_bootrom_headers",
"@pico-sdk//src/rp2_common/pico_bootrom:pico_bootrom_headers",
+ "@pico-sdk//src/rp2_common/pico_stdio_usb:reset_interface_headers",
],
) |
Filtering by `--vid` and `--pid` is not enough currently. I'm implementing the reboot interface for a custom device. But I'm not using the Raspberry PI vendor ID. There's no way currently to allow those third party devices to reboot. With this change I can reboot my device from application firmware into bootloader with: ``` picotool reboot --vid 0x32ac --pid 0x001f -f -u ``` Signed-off-by: Daniel Schaefer <[email protected]>
JohnAZoidberg
force-pushed
the
thirdparty-stdio_usb
branch
from
5788b3b
to
8593ec4
Compare
|
Thanks @armandomontanez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm implementing the reboot interface for a custom device. But I'm not using the Raspberry PI vendor ID.
There's no way currently to allow those third party devices to reboot.
With this change I can reboot my device from application firmware into bootloader with: