-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FluxCP 2.0 #233
FluxCP 2.0 #233
Conversation
Co-authored-by: Cydh Ramdh <[email protected]>
Co-authored-by: Cydh Ramdh <[email protected]>
Statement's `execute()` fix
Fixed Whoops prevents error logging
Attempt to fix theme directory lookup
Added realpath() to find the font Tested on Windows (PHP 5.4.16 and 7.2.12) and on Ubuntu 18.04 (7.2.12) Co-authored-by: Hyvraine <[email protected]>
(cherry picked from commit d9cec25)
…nt alpha to go beyond max value.
I don't really like using composer. prefer the website that is configured as it is currently using php. then import sql. connection settings in php and done. try to see cms like wordpress they work easily without having to do composer in the installation. |
That's the way for writing code like from 2010 maybe, but not now. Updating dependencies twice for a lifetime doesn't look good. If we want keep legacy-way, then we should not update anything then and just freeze anything except must have updates which is harder to implement every year. Also that's reason to keep away new contributors since they using PSR/Composer/Docker/CI while we dont provide support for it. Best we can do is Requirements list with PHP 5.2 included(7.4 EOL this year FYI). |
Actually it is possible from the developer side to use composer, but the final result sent to github should only be the final file and mysql only. So users only need to do a git pull and upgrade/import sql if needed, such as updating ratena. |
It's a bad practice to track dependencies on version control especially when you have a dependency management tool available. |
requires_once
hell..env
file. Provides more flexible developer experience.