chore(crypto): CRP-2438 rename clib tecdsa (dfinity#1903)

Renames `rs/crypto/internal/threshold_sig/tecdsa` to
`rs/crypto/internal/threshold_sig/canister_threshold_sig` because it now
also contains threshold Schnorr code.

Cargo.toml

@@ -74,8 +74,8 @@ members = [
     "rs/crypto/secp256k1",
     "rs/crypto/secrets_containers",
     "rs/crypto/internal/crypto_lib/threshold_sig/bls12_381",
-    "rs/crypto/internal/crypto_lib/threshold_sig/tecdsa",
-    "rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/test_utils",
+    "rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig",
+    "rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils",
     "rs/crypto/internal/crypto_lib/tls",
     "rs/crypto/internal/crypto_lib/types",
     "rs/crypto/internal/crypto_service_provider",

rs/crypto/BUILD.bazel

@@ -19,7 +19,7 @@ DEPENDENCIES = [
     "//rs/crypto/internal/crypto_lib/basic_sig/ed25519",
     "//rs/crypto/internal/crypto_lib/seed",
     "//rs/crypto/internal/crypto_lib/threshold_sig/bls12_381",
-    "//rs/crypto/internal/crypto_lib/threshold_sig/tecdsa",
+    "//rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig",
     "//rs/crypto/internal/crypto_lib/types",
     "//rs/crypto/internal/crypto_service_provider",
     "//rs/crypto/internal/logmon",
@@ -64,7 +64,7 @@ DEV_DEPENDENCIES = [
     "//rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256k1",
     "//rs/crypto/internal/crypto_lib/basic_sig/ecdsa_secp256r1",
     "//rs/crypto/internal/crypto_lib/basic_sig/rsa_pkcs1",
-    "//rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/test_utils",
+    "//rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils",
     "//rs/crypto/internal/crypto_lib/tls",
     "//rs/crypto/internal/crypto_service_provider/csp_proptest_utils",
     "//rs/crypto/internal/csp_test_utils",

rs/crypto/Cargo.toml

@@ -24,7 +24,7 @@ ic-crypto-internal-csp = { path = "internal/crypto_service_provider" }
 ic-crypto-internal-logmon = { path = "internal/logmon" }
 ic-crypto-internal-seed = { path = "internal/crypto_lib/seed" }
 ic-crypto-internal-threshold-sig-bls12381 = { path = "internal/crypto_lib/threshold_sig/bls12_381" }
-ic-crypto-internal-threshold-sig-ecdsa = { path = "internal/crypto_lib/threshold_sig/tecdsa" }
+ic-crypto-internal-threshold-sig-canister-threshold-sig = { path = "internal/crypto_lib/threshold_sig/canister_threshold_sig" }
 ic-crypto-internal-types = { path = "internal/crypto_lib/types" }
 ic-crypto-standalone-sig-verifier = { path = "standalone-sig-verifier" }
 ic-crypto-tls-cert-validation = { path = "node_key_validation/tls_cert_validation" }
@@ -60,7 +60,7 @@ ic-crypto-internal-basic-sig-rsa-pkcs1 = { path = "internal/crypto_lib/basic_sig
 ic-crypto-internal-csp-proptest-utils = { path = "internal/crypto_service_provider/csp_proptest_utils" }
 ic-crypto-internal-csp-test-utils = { path = "internal/csp_test_utils" }
 ic-crypto-internal-test-vectors = { path = "internal/test_vectors" }
-ic-crypto-internal-threshold-sig-ecdsa-test-utils = { path = "internal/crypto_lib/threshold_sig/tecdsa/test_utils" }
+ic-crypto-internal-threshold-sig-canister-threshold-sig-test-utils = { path = "internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils" }
 ic-crypto-internal-tls = { path = "internal/crypto_lib/tls" }
 ic-crypto-node-key-generation = { path = "node_key_generation" }
 ic-crypto-node-key-validation = { path = "node_key_validation" }

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/BUILD.bazel → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/BUILD.bazel

@@ -30,14 +30,14 @@ DEPENDENCIES = [
 
 MACRO_DEPENDENCIES = [
     # Keep sorted.
-    "//rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fe-derive",
+    "//rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fe-derive",
     "@crate_index//:paste",
     "@crate_index//:strum_macros",
 ]
 
 DEV_DEPENDENCIES = [
     # Keep sorted.
-    "//rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/test_utils",
+    "//rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils",
     "//rs/crypto/test_utils/reproducible_rng",
     "@crate_index//:assert_matches",
     "@crate_index//:bip32",
@@ -51,10 +51,10 @@ MACRO_DEV_DEPENDENCIES = []
 ALIASES = {}
 
 rust_library(
-    name = "tecdsa",
+    name = "canister_threshold_sig",
     srcs = glob(["src/**"]),
     aliases = ALIASES,
-    crate_name = "ic_crypto_internal_threshold_sig_ecdsa",
+    crate_name = "ic_crypto_internal_threshold_sig_canister_threshold_sig",
     proc_macro_deps = MACRO_DEPENDENCIES,
     rustc_flags = select({
         "//bazel:fuzzing_code_enabled": DEFAULT_RUSTC_FLAGS_FOR_FUZZING,
@@ -65,9 +65,9 @@ rust_library(
 )
 
 rust_test(
-    name = "tecdsa_test",
+    name = "canister_threshold_sig_test",
     aliases = ALIASES,
-    crate = ":tecdsa",
+    crate = ":canister_threshold_sig",
     proc_macro_deps = MACRO_DEPENDENCIES + MACRO_DEV_DEPENDENCIES,
     deps = DEPENDENCIES + DEV_DEPENDENCIES,
 )
@@ -80,7 +80,7 @@ rust_test_suite(
     aliases = ALIASES,
     compile_data = glob(["tests/data/*"]),
     proc_macro_deps = MACRO_DEPENDENCIES + MACRO_DEV_DEPENDENCIES,
-    deps = [":tecdsa"] + DEPENDENCIES + DEV_DEPENDENCIES,
+    deps = [":canister_threshold_sig"] + DEPENDENCIES + DEV_DEPENDENCIES,
 )
 
 rust_bench(
@@ -89,7 +89,7 @@ rust_bench(
     srcs = ["benches/dealings.rs"],
     deps = [
         # Keep sorted.
-        ":tecdsa",
+        ":canister_threshold_sig",
         "//rs/crypto/test_utils/reproducible_rng",
         "//rs/rust_canisters/canister_test",
         "//rs/types/types",
@@ -104,7 +104,7 @@ rust_bench(
     srcs = ["benches/group_ops.rs"],
     deps = [
         # Keep sorted.
-        ":tecdsa",
+        ":canister_threshold_sig",
         "//rs/crypto/test_utils/reproducible_rng",
         "@crate_index//:criterion",
         "@crate_index//:rand",
@@ -117,7 +117,7 @@ rust_bench(
     srcs = ["benches/hash2curve.rs"],
     deps = [
         # Keep sorted.
-        ":tecdsa",
+        ":canister_threshold_sig",
         "@crate_index//:criterion",
     ],
 )
@@ -128,7 +128,7 @@ rust_bench(
     srcs = ["benches/key_derivation.rs"],
     deps = [
         # Keep sorted.
-        ":tecdsa",
+        ":canister_threshold_sig",
         "//rs/crypto/test_utils/reproducible_rng",
         "//rs/types/types",
         "@crate_index//:criterion",
@@ -142,7 +142,7 @@ rust_bench(
     srcs = ["benches/poly.rs"],
     deps = [
         # Keep sorted.
-        ":tecdsa",
+        ":canister_threshold_sig",
         "//rs/crypto/test_utils/reproducible_rng",
         "@crate_index//:criterion",
         "@crate_index//:rand",
@@ -155,7 +155,7 @@ rust_bench(
     srcs = ["benches/zk.rs"],
     deps = [
         # Keep sorted.
-        ":tecdsa",
+        ":canister_threshold_sig",
         "//rs/crypto/test_utils/reproducible_rng",
         "@crate_index//:criterion",
         "@crate_index//:rand",

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/Cargo.toml → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "ic-crypto-internal-threshold-sig-ecdsa"
+name = "ic-crypto-internal-threshold-sig-canister-threshold-sig"
 version.workspace = true
 authors.workspace = true
 edition.workspace = true
@@ -38,7 +38,7 @@ assert_matches = { workspace = true }
 bip32 = { version = "0.5", features = ["secp256k1"] }
 criterion = { workspace = true }
 ed25519-dalek = { workspace = true }
-ic-crypto-internal-threshold-sig-ecdsa-test-utils = { path = "test_utils" }
+ic-crypto-internal-threshold-sig-canister-threshold-sig-test-utils = { path = "test_utils" }
 ic-crypto-test-utils-reproducible-rng = { path = "../../../../test_utils/reproducible_rng" }
 num-traits = { workspace = true }
 strum = { workspace = true }

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/benches/dealings.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/benches/dealings.rs

@@ -1,5 +1,5 @@
 use criterion::*;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use ic_crypto_test_utils_reproducible_rng::reproducible_rng;
 use ic_types::crypto::AlgorithmId;
 use ic_types::NumberOfNodes;

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/benches/group_ops.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/benches/group_ops.rs

@@ -1,5 +1,5 @@
 use criterion::*;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use ic_crypto_test_utils_reproducible_rng::reproducible_rng;
 use rand::{CryptoRng, Rng};
 

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/benches/hash2curve.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/benches/hash2curve.rs

@@ -1,5 +1,5 @@
 use criterion::*;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 
 fn hash2curve(c: &mut Criterion) {
     let input = "greetings humans".as_bytes();

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/benches/key_derivation.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/benches/key_derivation.rs

@@ -1,5 +1,5 @@
 use criterion::*;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use ic_crypto_test_utils_reproducible_rng::reproducible_rng;
 use ic_types::crypto::canister_threshold_sig::MasterPublicKey;
 use ic_types::crypto::AlgorithmId;

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/benches/poly.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/benches/poly.rs

@@ -1,5 +1,5 @@
 use criterion::*;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use ic_crypto_test_utils_reproducible_rng::reproducible_rng;
 use rand::{CryptoRng, Rng};
 

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/benches/zk.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/benches/zk.rs

@@ -1,5 +1,5 @@
 use criterion::*;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use ic_crypto_test_utils_reproducible_rng::reproducible_rng;
 use rand::Rng;
 

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/BUILD.bazel → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/BUILD.bazel

@@ -4,7 +4,7 @@ package(default_visibility = ["//visibility:private"])
 
 DEPENDENCIES = [
     # Keep sorted.
-    "//rs/crypto/internal/crypto_lib/threshold_sig/tecdsa",
+    "//rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig",
     "@crate_index//:arbitrary",
     "@crate_index//:hex",
     "@crate_index//:libfuzzer-sys",

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/Cargo.toml → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "tecdsa-fuzz"
+name = "canister-threshold-sig-fuzz"
 version = "0.0.0"
 publish = false
 authors.workspace = true
@@ -16,7 +16,7 @@ libfuzzer-sys = "0.4"
 num-bigint = { workspace = true }
 subtle = "2.4"
 
-[dependencies.ic-crypto-internal-threshold-sig-ecdsa]
+[dependencies.ic-crypto-internal-threshold-sig-canister-threshold-sig]
 path = ".."
 
 # Prevent this from interfering with workspaces

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/cbor_deserialize_dealing_seed_corpus/BUILD.bazel → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/cbor_deserialize_dealing_seed_corpus/BUILD.bazel

@@ -4,7 +4,7 @@ package(default_visibility = ["//visibility:private"])
 
 DEPENDENCIES = [
     # Keep sorted.
-    "//rs/crypto/internal/crypto_lib/threshold_sig/tecdsa",
+    "//rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig",
     "//rs/types/types",
     "@crate_index//:assert_matches",
     "@crate_index//:clap",

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/cbor_deserialize_dealing_seed_corpus/src/main.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/cbor_deserialize_dealing_seed_corpus/src/main.rs

@@ -1,5 +1,5 @@
 use clap::Parser;
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use ic_types::crypto::AlgorithmId;
 use ic_types::NumberOfNodes;
 use rand::thread_rng;

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/fuzz_targets/cbor_deserialize_dealing.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/fuzz_targets/cbor_deserialize_dealing.rs

@@ -1,7 +1,7 @@
 #![no_main]
 use libfuzzer_sys::fuzz_target;
 
-use ic_crypto_internal_threshold_sig_ecdsa::IDkgDealingInternal;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::IDkgDealingInternal;
 
 // This fuzzer tries to find panics in CBOR deserialization of dealings. We ignore errors
 // returned by the decoding, as these do not lead to panics. You can run the fuzzer locally:

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/fuzz_targets/cbor_deserialize_ecc_point.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/fuzz_targets/cbor_deserialize_ecc_point.rs

@@ -1,7 +1,7 @@
 #![no_main]
 use libfuzzer_sys::fuzz_target;
 
-use ic_crypto_internal_threshold_sig_ecdsa::{EccCurveType, EccPoint};
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::{EccCurveType, EccPoint};
 
 // This fuzzer tries to find panics in CBOR deserialization of ECC points. We ignore errors
 // returned by the decoding, as these do not lead to panics. You can run the fuzzer locally:

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/fuzz_targets/hash_to_point.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/fuzz_targets/hash_to_point.rs

@@ -2,7 +2,7 @@
 use arbitrary::{Arbitrary, Unstructured};
 use libfuzzer_sys::fuzz_target;
 
-use ic_crypto_internal_threshold_sig_ecdsa::{EccCurveType, EccPoint};
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::{EccCurveType, EccPoint};
 
 // This fuzzer tries to find panics in hashing to ECC points. We ignore errors
 // returned by the function, as these do not lead to panics. You can run the fuzzer locally:

rs/crypto/internal/crypto_lib/threshold_sig/tecdsa/fuzz/fuzz_targets/scalar.rs → rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/fuzz/fuzz_targets/scalar.rs

@@ -1,7 +1,7 @@
 #![no_main]
 use libfuzzer_sys::fuzz_target;
 
-use ic_crypto_internal_threshold_sig_ecdsa::*;
+use ic_crypto_internal_threshold_sig_canister_threshold_sig::*;
 use num_bigint::BigUint;
 
 fn prime_for(curve: EccCurveType) -> BigUint {