Add ability to override defaults #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,6 +71,10 @@ | |||
| <SubType>Designer</SubType> | |||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | |||
| </None> | |||
| <None Include="ILRepack.Lib.MSBuild.Task.props"> | |||
| <SubType>Designer</SubType> | |||
There was a problem hiding this comment.
You can always delete SubType Designer
| @@ -71,6 +71,10 @@ | |||
| <SubType>Designer</SubType> | |||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | |||
| </None> | |||
| <None Include="ILRepack.Lib.MSBuild.Task.props"> | |||
| <SubType>Designer</SubType> | |||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | |||
There was a problem hiding this comment.
Always breaks incrementality, it's better to use PreserveNewest
| @@ -1,5 +1,7 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <PropertyGroup> | |||
There was a problem hiding this comment.
no need for an empty PropertyGroup here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't fully test the backcompat scenario but for basic usages it appears to work fine.
The intention of my change was to give the ability to give the user a change to customize with out having to duplicate your targets and maintain a separate copy of them. I also implemented it in a way that I believe will provide for back compat for those who are still dependent on your task.
Anyway feel free to reject this change I just thought I would contribute it back.