Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core][experimental] Avoid serialization for data passed between two tasks on the same actor" #45925

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

aslonnie
Copy link
Collaborator

Reverts #45591

tests (//python/ray/dag:test_torch_tensor_dag_gpu and some more) failing with segfault:

examples:

tests against commits before this PR do not show similar failures.

@aslonnie
Copy link
Collaborator Author

cc @can-anyscale

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Jun 13, 2024
@aslonnie
Copy link
Collaborator Author

related:

#45920
#45922
#45923

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert it. I will take a look. I think there might be some inconsistencies between my PR and the master branch that occurred when we merged the PR.

@aslonnie aslonnie merged commit af3e54e into master Jun 13, 2024
6 checks passed
@aslonnie aslonnie deleted the revert-45591-local-channel branch June 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants