[Data] Add Dataset.rename_columns
#47906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
omatthew98
reviewed
Oct 4, 2024
raulchen
approved these changes
Oct 4, 2024
| raise ValueError( | ||
| "Expected `concurrency` to be an integer or `None`, but got " | ||
| f"{concurrency}." | ||
| ) |
There was a problem hiding this comment.
nit, concurrency validation will be done within map_batches. no need to add it here
There was a problem hiding this comment.
I'm performing an additional validation here to avoid this confusing error message when you pass a tuple to concurrency:
ValueError:
concurrencyis set as a tuple of integers, butfnis not a callable class: <function Dataset.rename_columns..rename_columns at 0x166532550>. Useconcurrency=nto control maximum number of workers to use.
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
Fixes ray-project#32261 --------- Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Fixes #32261
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.