Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state'. #47914

Conversation

simonsays1980
Copy link
Collaborator

@simonsays1980 simonsays1980 commented Oct 6, 2024

Why are these changes needed?

When get_state is called it tries to turn the space_struct into a dictionary by using gym_space_to_dict. This errors out for composite spaces because the outer space is not a space but a container (i.e. the sample fo that space). This PR fixes this error, but focusing on the space attribute which isa true gymnasium.spaces.Space in its outer space and rebuild the space_struct in from_state when existent.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simonsays1980 simonsays1980 added bug Something that is supposed to be working; but isn't rllib RLlib related issues rllib-env rllib env related issues labels Oct 6, 2024
@simonsays1980 simonsays1980 marked this pull request as ready for review October 6, 2024 11:23
@sven1977 sven1977 changed the title [RLlib] - Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state' [RLlib] Fix small bug in 'InfiniteLookBackBuffer.get_state/from_state'. Oct 8, 2024
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @simonsays1980 .

@sven1977 sven1977 enabled auto-merge (squash) October 8, 2024 17:42
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Oct 8, 2024
@github-actions github-actions bot disabled auto-merge October 9, 2024 08:56
Signed-off-by: simonsays1980 <[email protected]>
@sven1977 sven1977 merged commit 00829fe into ray-project:master Oct 10, 2024
5 checks passed
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@simonsays1980 simonsays1980 deleted the fix-get-state-of-infinite-lookback-buffer branch November 22, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-env rllib env related issues rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants