Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Fix unequal partitions when grouping by multiple keys #47924

Merged
merged 4 commits into from
Oct 9, 2024
Merged

[Data] Fix unequal partitions when grouping by multiple keys #47924

merged 4 commits into from
Oct 9, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

See #45303

Related issue number

Fixes #45303

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
a6e9d55 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Add comments
0fd2b10 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani
Add comments
f3154c6 
Signed-off-by: Balaji Veeramani <[email protected]>
@alexeykudinkin alexeykudinkin added the go add ONLY when ready to merge, run all tests label Oct 8, 2024
@bveeramani
Adderss review comments
00861bb 
Signed-off-by: Balaji Veeramani <[email protected]>
@bveeramani bveeramani enabled auto-merge (squash) October 9, 2024 16:14
@bveeramani bveeramani merged commit 4824839 into master Oct 9, 2024
6 checks passed
@bveeramani bveeramani deleted the fix-sort branch October 9, 2024 17:11
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@bveeramani @ujjawal-khare
[Data] Fix unequal partitions when grouping by multiple keys (ray-pro…
988d6f7 
…ject#47924)

Fixes ray-project#45303

---------

Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: ujjawal-khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@alexeykudinkin alexeykudinkin alexeykudinkin approved these changes

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@raulchen raulchen

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data] Heavy data skew after groupby
3 participants
@bveeramani @alexeykudinkin @raulchen