[Fix][Core] Change grpc_server_req_process_time_ms metric type to histogram #47932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynewang
reviewed
Oct 8, 2024
| @@ -59,7 +59,7 @@ | |||
| "ray_internal_num_spilled_tasks", | |||
| # "ray_unintentional_worker_failures_total", | |||
| # "ray_node_failure_total", | |||
| "ray_grpc_server_req_process_time_ms", | |||
| "ray_grpc_server_req_process_time_ms_sum", | |||
There was a problem hiding this comment.
I think we should also have ray_grpc_server_req_process_time_ms_bucket and ray_grpc_server_req_process_time_ms_count
…togram Closes: ray-project#47486 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
bugfix/#47486-grpc-server-req-time-guage-to-histogram
branch
from
280a2be
to
5e0ee4e
Compare
Add two more metrics: * ray_grpc_server_req_process_time_ms_bucket * ray_grpc_server_req_process_time_ms_count Closes: ray-project#47486 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
bugfix/#47486-grpc-server-req-time-guage-to-histogram
branch
from
5e0ee4e
to
1deb075
Compare
rynewang
approved these changes
Oct 9, 2024
…ime-guage-to-histogram
MortalHappiness
force-pushed
the
bugfix/#47486-grpc-server-req-time-guage-to-histogram
branch
from
5d57616
to
0feac08
Compare
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
…togram (ray-project#47932) Signed-off-by: Chi-Sheng Liu <[email protected]> Co-authored-by: Ruiyang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See the description in the corresponding issue for details.
Related issue number
Closes: #47486
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.